You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/11 00:38:48 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42847: [WIP] ArrowUtils support CalendarIntervalType

HyukjinKwon commented on code in PR #42847:
URL: https://github.com/apache/spark/pull/42847#discussion_r1320898412


##########
sql/api/src/main/scala/org/apache/spark/sql/util/ArrowUtils.scala:
##########
@@ -118,6 +118,18 @@ private[sql] object ArrowUtils {
             nullable = false,
             timeZoneId,
             largeVarTypes)).asJava)
+      case CalendarIntervalType =>
+        val fields = Seq(

Review Comment:
   Hm, can we try to find the equivalent type in Arrow? e.g., https://arrow.apache.org/docs/cpp/api/datatype.html#_CPPv4N5arrow4Type4type23INTERVAL_MONTH_DAY_NANOE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org