You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "tongke6 (via GitHub)" <gi...@apache.org> on 2025/01/20 09:37:13 UTC
[PR] Chore: minimize dependence to avoid depends on protoc_lib (brpc)
tongke6 opened a new pull request, #2881:
URL: https://github.com/apache/brpc/pull/2881
### What problem does this PR solve?
Issue Number:
Problem Summary:
在最新的 protobuf 版本里，protoc_lib 包含 main 函数，而 `//:bprc` --> `//:mcpack2pb` --> `@com_google_protobuf//:protoc_lib`，导致所有依赖 brpc 的 gtest 且没有显式写 main 函数的测试，实际上运行的是 protoc 的程序。比如issue https://github.com/protocolbuffers/protobuf/issues/12887
这个 PR 尝试解决这个问题，将 `//:mcpack2pb` 的依赖最小化。
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
NO
- Breaking backward compatibility(向后兼容性): NO compatibility issue.
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Chore: minimize dependence to avoid depends on protoc_lib (brpc)
Posted by "tongke6 (via GitHub)" <gi...@apache.org>.
tongke6 commented on PR #2881:
URL: https://github.com/apache/brpc/pull/2881#issuecomment-2608767221
@chenBright 你好，这个 PR 可以合入了吗？还有什么需要我做的吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Chore: minimize dependence to avoid depends on protoc_lib (brpc)
Posted by "ZhengweiZhu (via GitHub)" <gi...@apache.org>.
ZhengweiZhu commented on PR #2881:
URL: https://github.com/apache/brpc/pull/2881#issuecomment-2692268006
这个PR合入后，貌似bazel （版本6.4.0）编译会失败。 revert这个补丁后编译成功。
/brpc# bazel build //example:echo_c++_server
ERROR: /brpc/BUILD.bazel:427:11: no such package '@com_google_protobuf//src/google/protobuf/compiler': BUILD file not found in directory 'src/google/protobuf/compiler' of external repository @com_google_protobuf. Add a BUILD file to a directory to mark it as a package. and referenced by '//:mcpack2pb'
ERROR: Analysis of target '//example:echo_c++_server' failed; build aborted:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Chore: minimize dependence to avoid depends on protoc_lib (brpc)
Posted by "yanglimingcn (via GitHub)" <gi...@apache.org>.
yanglimingcn commented on PR #2881:
URL: https://github.com/apache/brpc/pull/2881#issuecomment-2608659206
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Chore: minimize dependence to avoid depends on protoc_lib (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright merged PR #2881:
URL: https://github.com/apache/brpc/pull/2881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org