You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/03/24 14:24:04 UTC

[GitHub] [daffodil] tuxji commented on a change in pull request #481: ADD test for "%%" to bypass existing test for "%NL"

tuxji commented on a change in pull request #481:
URL: https://github.com/apache/daffodil/pull/481#discussion_r600525360



##########
File path: daffodil-lib/src/main/scala/org/apache/daffodil/cookers/Cookers.scala
##########
@@ -63,7 +63,7 @@ object InitiatorCooker extends DelimiterCooker("initiator")
 
 object TerminatorCooker extends DelimiterCooker("terminator")
 
-object TerminatorCookerNoES extends DelimiterCookerNoES("terminator")
+object TerminatorCookerNoES extends DelimiterCookerNoSoleES("terminator")

Review comment:
       Is it appropriate for `TerminatorCookerNoES` to keep its original name or should it be renamed to `TerminatorCookieNoSoleES`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org