You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Mona Chitnis (JIRA)" <ji...@apache.org> on 2012/07/11 19:59:37 UTC
[jira] [Created] (OOZIE-907) Default ACL settings for Oozie
launcher
Mona Chitnis created OOZIE-907:
----------------------------------
Summary: Default ACL settings for Oozie launcher
Key: OOZIE-907
URL: https://issues.apache.org/jira/browse/OOZIE-907
Project: Oozie
Issue Type: Bug
Affects Versions: trunk, 3.2.1
Reporter: Mona Chitnis
Assignee: Mona Chitnis
Fix For: trunk, 3.2.1
This is about the oozie settings:
- oozie.launcher.mapreduce.job.acl-view-job
- oozie.launcher.mapreduce.job.acl-modify-job
Currently, these settings default to the most restrictive permissions.
Instead they should default to the values set by the user
for the settings:
- mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
- mapreduce.job.acl-modify-job =>
oozie.launcher.mapreduce.job.acl-modify-job
Typically, users will want to set these same values for the mapreduce and
oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414183#comment-13414183 ]
Alejandro Abdelnur commented on OOZIE-907:
------------------------------------------
I may be missing something, but why not use the oozie job ACL here (the old oozie job group)?
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415574#comment-13415574 ]
Mona Chitnis commented on OOZIE-907:
------------------------------------
Added the ACL properties to SPECIAL_PROPERTIES set. Aren't the explicit kerberos.principal properties removed since version 3.2? They are still lying around in this set.
Should the Group name be given precedence as job-acl for launcher or the user passing a specific value with 'oozie.launcher."?
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch, OOZIE-907v3.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416349#comment-13416349 ]
Virag Kothari commented on OOZIE-907:
-------------------------------------
committed to trunk
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch, OOZIE-907v3.patch, OOZIE-907v4.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413968#comment-13413968 ]
Virag Kothari commented on OOZIE-907:
-------------------------------------
Had offline discussion with Mona.
+1 after removing couple of lines where launcher conf is overridden and test cases are separated.
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-907:
-------------------------------
Attachment: OOZIE-907v4.patch
v4: removed the unnecessary block setting launcherconf modify-job-acl to group name. Since actionConf acl is already set to group name in caller function, the new function in this patch handles propagating that acl to launcherConf as a default.
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch, OOZIE-907v3.patch, OOZIE-907v4.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-907:
-------------------------------
Attachment: OOZIE-907v3.patch
After discussing with Mohammad, removing the prefix "oozie.launcher" of the ACL properies from the launcherConf object since it is stripped for the other properties as well.
Also, changed the function into reusable code applicable to other set of properties too.
Addressed Virag's comment and separated out the tests case-by-case for clarity
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch, OOZIE-907v3.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-907:
-------------------------------
Attachment: (was: OOZIE-907v3.patch)
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch, OOZIE-907v3.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-907:
-------------------------------
Attachment: OOZIE-907.patch
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413894#comment-13413894 ]
Mona Chitnis commented on OOZIE-907:
------------------------------------
That is done to account for the case when both "oozie.launcher.<property>" and "<property>" values are specified. Otherwise JavaActionExecutor injectLauncherProperties() copies over the value of the first to the second.
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413857#comment-13413857 ]
Virag Kothari commented on OOZIE-907:
-------------------------------------
Why is this being done?
launcherConf.set(CONF_OOZIE_ACL_VIEW_JOB, actionConf.get(CONF_OOZIE_ACL_VIEW_JOB));
The value can be null.
I think this line should be removed. The acl property for 'oozie.launcher' is already set. Same comment for acl modify.
Also, its better to create separate test methods for each of the cases
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414197#comment-13414197 ]
Mona Chitnis commented on OOZIE-907:
------------------------------------
If user has specified value for the property 'mapreduce.job.acl-view-job' or modify-job, then that will get set. otherwise it will get set to the group name. I can add a notNull condition for this launcherJobConf property in the block
if (context.getWorkflow().getAcl() != null) {
// setting the group owning the Oozie job to allow anybody in that
// group to kill the jobs.
launcherJobConf.set("mapreduce.job.acl-modify-job", context.getWorkflow().getAcl());
}
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-907:
-------------------------------
Attachment: OOZIE-907v2.patch
Addressed Virag's review comments.
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414207#comment-13414207 ]
Mona Chitnis commented on OOZIE-907:
------------------------------------
To supplement my comment above, the action configuration's acl value does get set to the group name (in submitLauncher method) before my set-to-defaults function is called. So this is the value can will get copied as a default from actionConf to launcherConf, and not overridden.
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-907:
-------------------------------
Attachment: OOZIE-907v3.patch
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch, OOZIE-907v3.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-907) Default ACL settings for Oozie
launcher
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413005#comment-13413005 ]
Virag Kothari commented on OOZIE-907:
-------------------------------------
*The patch overrides the 'oozie.launcher' settings with the default setting. This seems to be opposite of what is stated in JIRA.
*Only if the property exists, it should be set. Otherwise it will be set to null which is undesirable
if (actionConf.exists(CONF_OOZIE_ACL_VIEW_JOB)){
launcherConf.set()
}
*TestCases need to account for the cases in above comments
*Other launcher related conf is done within JavaActionExecutor. What is the need for creating a static method in LauncherMapper?
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira