[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #17536: [improve][build] Create images before build python wheels

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #17536:
URL: https://github.com/apache/pulsar/pull/17536#discussion_r979686435


##########
pulsar-client-cpp/docker/build-wheels.sh:
##########
@@ -27,6 +27,18 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
 ROOT_DIR=`cd $(dirname $0)/../..; pwd`
 cd $ROOT_DIR
 
+skip_create_images=0
+while [[ "$1" == "--skip-create-images" ]]; do
+  skip_create_images=1
+  shift
+done
+
+if [ $skip_create_images -ne 1 ]; then
+  cd ./pulsar-client-cpp/docker
+  ./create-images.sh
+  pushd

Review Comment:
   ```suggestion
     pushd ./pulsar-client-cpp/docker
     ./create-images.sh
     popd
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org