You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/03/29 03:35:49 UTC

[GitHub] ralf0131 commented on a change in pull request #1506: Update ServiceConfig.java

ralf0131 commented on a change in pull request #1506: Update ServiceConfig.java
URL: https://github.com/apache/incubator-dubbo/pull/1506#discussion_r177946345
 
 

 ##########
 File path: dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
 ##########
 @@ -491,7 +491,7 @@ private void doExportUrlsFor1Protocol(ProtocolConfig protocolConfig, List<URL> r
                 }
                 if (registryURLs != null && !registryURLs.isEmpty()) {
                     for (URL registryURL : registryURLs) {
-                        url = url.addParameterIfAbsent("dynamic", registryURL.getParameter("dynamic"));
+                        url = url.addParameterIfAbsent(Constants.DYNAMIC_KEY, registryURL.getParameter("dynamic"));
 
 Review comment:
   Why is the string in `registryURL.getParameter("dynamic")` not getting replaced with `Constants.DYNAMIC_KEY`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services