You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by zs...@apache.org on 2020/12/03 01:32:37 UTC
[spark] branch master updated: [SPARK-32896][SS][FOLLOW-UP] Rename
the API to `toTable`
This is an automated email from the ASF dual-hosted git repository.
zsxwing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 6fa797e [SPARK-32896][SS][FOLLOW-UP] Rename the API to `toTable`
6fa797e is described below
commit 6fa797e977412d071dd4dc079053ec64a21b3041
Author: Yuanjian Li <yu...@databricks.com>
AuthorDate: Wed Dec 2 17:31:10 2020 -0800
[SPARK-32896][SS][FOLLOW-UP] Rename the API to `toTable`
### What changes were proposed in this pull request?
As the discussion in https://github.com/apache/spark/pull/30521#discussion_r531463427, rename the API to `toTable`.
### Why are the changes needed?
Rename the API for further extension and accuracy.
### Does this PR introduce _any_ user-facing change?
Yes, it's an API change but the new API is not released yet.
### How was this patch tested?
Existing UT.
Closes #30571 from xuanyuanking/SPARK-32896-follow.
Authored-by: Yuanjian Li <yu...@databricks.com>
Signed-off-by: Shixiong Zhu <zs...@gmail.com>
---
.../main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala | 2 +-
.../org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala b/sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
index d67e175..9e35997 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
@@ -304,7 +304,7 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
* @since 3.1.0
*/
@throws[TimeoutException]
- def saveAsTable(tableName: String): StreamingQuery = {
+ def toTable(tableName: String): StreamingQuery = {
this.source = SOURCE_NAME_TABLE
this.tableName = tableName
startInternal(None)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala
index 062b106..bf85043 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala
@@ -291,7 +291,7 @@ class DataStreamTableAPISuite extends StreamTest with BeforeAndAfter {
val query = inputDF
.writeStream
.option("checkpointLocation", checkpointDir.getAbsolutePath)
- .saveAsTable(tableIdentifier)
+ .toTable(tableIdentifier)
inputData.addData(newInputs: _*)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org