[GitHub] [storm] srdo commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r303234558
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java
 ##########
 @@ -344,11 +344,11 @@ private static boolean areAllWorkersWaiting() {
              LocalDRPC drpc = new LocalDRPC(local.metricRegistry);
              DRPCClient.LocalOverride drpcOverride = new DRPCClient.LocalOverride(drpc)) {
 
-            T ret = c.call();
             LOG.info("\n\n\t\tRUNNING LOCAL CLUSTER for {} seconds.\n\n", ttlSec);
             Thread.sleep(ttlSec * 1000);
 
             LOG.info("\n\n\t\tSTOPPING LOCAL MODE CLUSTER\n\n");
+            T ret = c.call();
 
 Review comment:
   This can't be moved, the sleep above needs to happen after the call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services