You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/07 03:25:39 UTC

[GitHub] [shardingsphere] wgy8283335 opened a new issue #9604: Why are the keywords treated as the identifier?

wgy8283335 opened a new issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604


   ## Why are the keywords treated as the identifier?
   
   Since the rule identifier is specified as IDENTIFIER_, why add unreservedWord in the identifier?
   The unreserved words are the subset of the IDENTIFIER.
   ```
   identifier
       : IDENTIFIER_ | unreservedWord
       ;
   ```
   ![image](https://user-images.githubusercontent.com/22066046/110227845-45729c80-7f37-11eb-9ed4-391c1fb8fbdf.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Liangda-w commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
Liangda-w commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-797549210


   Hi @jingshanglu, @wgy8283335 
   
   I'm a also a little bit confused by `unreservedWord`. [Here ](https://docs.oracle.com/cd/B19306_01/em.102/b40103/app_oracle_reserved_words.htm)I've found the list of reserved words in Oracle, however some of them appear in our `unreservedWord` (for example `ROLE`, `UNUSED`.... which are also defined in OracleKeyword.g4). Should we actually delete those words to keep in line with others?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Liangda-w commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
Liangda-w commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-816841455


   > @jingshanglu
   > To add words into unreservedWord, shall we follow this link "https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Oracle-SQL-Reserved-Words.html#GUID-55C49D1E-BE08-4C50-A9DD-8593EB925612"?
   
   @wgy8283335 oh yes! I'm sorry that I looked at an older release before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-792425259


   @wgy8283335 Unreserved words can be used as variable name.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-795136619


   > So, should all of the keyWords be put in the 'unreservedWord' rule? @jingshanglu
   
   Only a part of keywords are `unreservedWord` words. @wgy8283335 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-796479174


   > > > So, should all of the keyWords be put in the 'unreservedWord' rule? @jingshanglu
   > > 
   > > 
   > > Only a part of keywords are unreserved words. @wgy8283335
   > 
   > Thank you. And what kind of keywords should be unreserved words? @jingshanglu
   
   @wgy8283335 Each DB has its own list of reserved words, such as [MySQL](https://dev.mysql.com/doc/refman/8.0/en/keywords.html)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-800773699


   @jingshanglu
   To add words into unreservedWord, shall we follow this link "https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Oracle-SQL-Reserved-Words.html#GUID-55C49D1E-BE08-4C50-A9DD-8593EB925612"? 
   
   > > Hi @jingshanglu, @wgy8283335
   > > I'm a also a little bit confused by `unreservedWord`. [Here ](https://docs.oracle.com/cd/B19306_01/em.102/b40103/app_oracle_reserved_words.htm)I've found the list of reserved words in Oracle, however some of them appear in our `unreservedWord` (for example `ROLE`, `UNUSED`.... which are also defined in OracleKeyword.g4). Should we actually delete those words to keep in line with others?
   > 
   > I think we should correct `unreservedword` according to the official list. @Liangda-w @wgy8283335
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-799986122


   > Hi @jingshanglu, @wgy8283335
   > 
   > I'm a also a little bit confused by `unreservedWord`. [Here ](https://docs.oracle.com/cd/B19306_01/em.102/b40103/app_oracle_reserved_words.htm)I've found the list of reserved words in Oracle, however some of them appear in our `unreservedWord` (for example `ROLE`, `UNUSED`.... which are also defined in OracleKeyword.g4). Should we actually delete those words to keep in line with others?
   
   I think we should correct `unreservedword` according to the official list. @Liangda-w @wgy8283335 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu edited a comment on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
jingshanglu edited a comment on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-795136619


   > So, should all of the keyWords be put in the 'unreservedWord' rule? @jingshanglu
   
   Only a part of keywords are unreserved words. @wgy8283335 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 edited a comment on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
wgy8283335 edited a comment on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-793276545


   So, should all of the keyWords be put in the 'unreservedWord' rule? @jingshanglu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 closed issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
wgy8283335 closed issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 edited a comment on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
wgy8283335 edited a comment on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-796471982


   > > So, should all of the keyWords be put in the 'unreservedWord' rule? @jingshanglu
   > 
   > Only a part of keywords are unreserved words. @wgy8283335
   
   Thank you. And what kind of keywords should be unreserved words? @jingshanglu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-796471982


   > > So, should all of the keyWords be put in the 'unreservedWord' rule? @jingshanglu
   > 
   > Only a part of keywords are unreserved words. @wgy8283335
   
   Thank you. And what kind of keywords should be unreserved words?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on issue #9604: Why are the keywords treated as the identifier?

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on issue #9604:
URL: https://github.com/apache/shardingsphere/issues/9604#issuecomment-793276545


   So, should all of the keyWords be put in the 'unreservedWord' rule?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org