[GitHub] [incubator-superset] villebro commented on issue #8183: How to pass time filters to SQL Lab queries

[GitBox <gi...@apache.org>]

villebro commented on issue #8183: How to pass time filters to SQL Lab queries
URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-529081217
 
 
   There's a few things that could be done. One is adding more comprehensive builtin jinja functions that autogenerate where clauses like @rubypollev proposes. The problem with this approach is that the query can become quite messy and difficult to read/maintain.
   
   Another approach would be adding full CTE support, where one could in essence write the join as a CTE, which would then expose a flattened view of the complex query. In this approach any where clauses should be pushed down into the complex queries automatically without any jinja trickery. Adding full CTE support should be quite doable, and something I'd like to do at some point if people would find it valuable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org