You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/09/14 08:52:17 UTC

[GitHub] [incubator-opendal] Xuanwo opened a new issue, #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Xuanwo opened a new issue, #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064

   OpenDAL used to passing `content_type`, `cache_control` directly like the following:
   
   ```rust
   pub fn azblob_put_blob_request(
       &self,
       path: &str,
       size: Option<u64>,
       content_type: Option<&str>,
       cache_control: Option<&str>,
       body: AsyncBody,
   ) -> Result<Request<AsyncBody>> {}
   ```
   
   It's not good and hard to maintain, sometimes clippy will raising warning for our code. So it's time for us to migrate code like this to passing `OpWrite`. For example, we can change the previous code to:
   
   ```diff
   pub fn azblob_put_blob_request(
       &self,
       path: &str,
       size: Option<u64>,
   -   content_type: Option<&str>,
   -   cache_control: Option<&str>,
   +   args: &OpWrite,
       body: AsyncBody,
   ) -> Result<Request<AsyncBody>> {}
   ```
   
   ## Tasks
   
   - [ ] azblob
   - [ ] azdls
   - [ ] cos
   - [ ] dropbox
   - [ ] gcs
   - [ ] http
   - [ ] obs
   - [ ] onedrive
   - [ ] oss
   - [ ] s3
   - [ ] wasabi
   - [ ] webdav
   - [ ] webhdfs
   - [ ] 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] sysu-yunz commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "sysu-yunz (via GitHub)" <gi...@apache.org>.
sysu-yunz commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719490729

   Can I have a chance to contribute? I want to try oss.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] hanxuanliang commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "hanxuanliang (via GitHub)" <gi...@apache.org>.
hanxuanliang commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719582524

   Hi, @Xuanwo
   May I have a try the `obs`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] sunheyi6 commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "sunheyi6 (via GitHub)" <gi...@apache.org>.
sunheyi6 commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719152883

   Hi,@Xuanwo 
   I want to s3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719153825

   @miroim & @sunheyi6, DONE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] liul85 commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "liul85 (via GitHub)" <gi...@apache.org>.
liul85 commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719303837

   Hi @Xuanwo I will take `azdls`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] acehinnnqru commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "acehinnnqru (via GitHub)" <gi...@apache.org>.
acehinnnqru commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719291124

   I want to try: azblob


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] dqhl76 commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719296807

   > I want to try: azblob
   
   Cool, have fun!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] miroim commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "miroim (via GitHub)" <gi...@apache.org>.
miroim commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719150594

   Hi, @Xuanwo 
   May I have a try the `http`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719895595

   > This doesn't look hard, I'm new to Rust, so could you let me try refactoring Webdav?
   
   Of course, have fun!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] ImSingee commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "ImSingee (via GitHub)" <gi...@apache.org>.
ImSingee commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719216500

   So interesting form! I want to try dropbox


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] nasnoisaac commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "nasnoisaac (via GitHub)" <gi...@apache.org>.
nasnoisaac commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1721150099

   I want to try `onedrive`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] cxorm commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "cxorm (via GitHub)" <gi...@apache.org>.
cxorm commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719097878

   Hi @Xuanwo ,
   Could I take this issue and I would take some time to investigate it if you don't mind ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1724044036

   Thank you all! It's my honor to work with you 🫶


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] acehinnnqru commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "acehinnnqru (via GitHub)" <gi...@apache.org>.
acehinnnqru commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719494774

   > I want to try: azblob
   
   I also done: cos


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] laipz8200 commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "laipz8200 (via GitHub)" <gi...@apache.org>.
laipz8200 commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719893558

   This doesn't look hard, I'm new to Rust, so could you let me try refactoring Webdav?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] cxorm commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "cxorm (via GitHub)" <gi...@apache.org>.
cxorm commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719116199

   > > Could I take this issue and I would take some time to investigate it if you don't mind ?
   > 
   > How about selecting a service that allows others to work concurrently with you?
   
   Thank you for the reminder,
   I want to do webhdfs first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719100124

   > Could I take this issue and I would take some time to investigate it if you don't mind ?
   
   How about selecting a service that allows others to work concurrently with you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo closed issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions
URL: https://github.com/apache/incubator-opendal/issues/3064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] wavty commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "wavty (via GitHub)" <gi...@apache.org>.
wavty commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719719375

   I want to try: gcs @Xuanwo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #3064: refactor: Passing `OpXxxx` instead of content_type, cache_control,... in functions

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3064:
URL: https://github.com/apache/incubator-opendal/issues/3064#issuecomment-1719126702

   > I want to do webhdfs first.
   
   Great, I have marked `webhdfs` for you. Have fun!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org