You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/07/14 18:22:17 UTC
Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding automation tests for LB for secondary IP
Diffs
-----
test/integration/component/test_lb_secondary_ip.py PRE-CREATION
tools/marvin/marvin/lib/base.py 1a32275
Diff: https://reviews.apache.org/r/23452/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/#review51364
-----------------------------------------------------------
Ship it!
Ship It!
- sanjeev n
On Aug. 22, 2014, 6:24 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23452/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 6:24 a.m.)
>
>
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation tests for LB for secondary IP
>
>
> Diffs
> -----
>
> test/integration/component/test_lb_secondary_ip.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py a93b883
> tools/marvin/marvin/lib/base.py f0d53a6
>
> Diff: https://reviews.apache.org/r/23452/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/#review51361
-----------------------------------------------------------
Ship it!
- sanjeev n
On Aug. 22, 2014, 6:24 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23452/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 6:24 a.m.)
>
>
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation tests for LB for secondary IP
>
>
> Diffs
> -----
>
> test/integration/component/test_lb_secondary_ip.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py a93b883
> tools/marvin/marvin/lib/base.py f0d53a6
>
> Diff: https://reviews.apache.org/r/23452/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 6:24 a.m.)
Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
Changes
-------
Review Changes.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding automation tests for LB for secondary IP
Diffs (updated)
-----
test/integration/component/test_lb_secondary_ip.py PRE-CREATION
tools/marvin/marvin/config/test_data.py a93b883
tools/marvin/marvin/lib/base.py f0d53a6
Diff: https://reviews.apache.org/r/23452/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Aug. 12, 2014, 11:07 a.m., sanjeev n wrote:
> > test/integration/component/test_lb_secondary_ip.py, line 205
> > <https://reviews.apache.org/r/23452/diff/2/?file=658387#file658387line205>
> >
> > Add Assertion to check whether assigning lb rule to secondary ip address is success or not. Applicable in all tests
Added common function to check that LB rule is created for given ip addresses or not.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/#review50299
-----------------------------------------------------------
On Aug. 22, 2014, 6:24 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23452/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 6:24 a.m.)
>
>
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation tests for LB for secondary IP
>
>
> Diffs
> -----
>
> test/integration/component/test_lb_secondary_ip.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py a93b883
> tools/marvin/marvin/lib/base.py f0d53a6
>
> Diff: https://reviews.apache.org/r/23452/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/#review50299
-----------------------------------------------------------
test/integration/component/test_lb_secondary_ip.py
<https://reviews.apache.org/r/23452/#comment87988>
Add Assertion to check whether assigning lb rule to secondary ip address is success or not. Applicable in all tests
- sanjeev n
On Aug. 12, 2014, 10:05 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23452/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 10:05 a.m.)
>
>
> Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation tests for LB for secondary IP
>
>
> Diffs
> -----
>
> test/integration/component/test_lb_secondary_ip.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py a93b883
> tools/marvin/marvin/lib/base.py f0d53a6
>
> Diff: https://reviews.apache.org/r/23452/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 10:05 a.m.)
Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
Changes
-------
Updated patch with SSH issue resolved for secondary IP. Enabled all the test cases which were facing this issue.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding automation tests for LB for secondary IP
Diffs (updated)
-----
test/integration/component/test_lb_secondary_ip.py PRE-CREATION
tools/marvin/marvin/config/test_data.py a93b883
tools/marvin/marvin/lib/base.py f0d53a6
Diff: https://reviews.apache.org/r/23452/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/
-----------------------------------------------------------
(Updated July 25, 2014, 12:25 p.m.)
Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding automation tests for LB for secondary IP
Diffs
-----
test/integration/component/test_lb_secondary_ip.py PRE-CREATION
tools/marvin/marvin/lib/base.py 1a32275
Diff: https://reviews.apache.org/r/23452/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for
secondary IP
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23452/
-----------------------------------------------------------
(Updated July 23, 2014, 6:32 a.m.)
Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding automation tests for LB for secondary IP
Diffs
-----
test/integration/component/test_lb_secondary_ip.py PRE-CREATION
tools/marvin/marvin/lib/base.py 1a32275
Diff: https://reviews.apache.org/r/23452/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar