You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/21 14:04:45 UTC
[GitHub] [airflow] josh-fell opened a new pull request, #24582: Update providers to use functools compat for ``cached_property``
josh-fell opened a new pull request, #24582:
URL: https://github.com/apache/airflow/pull/24582
Now that all providers have a minimum Airflow version of 2.2.0, `cached_property` references should be replaced with `airflow.compat.functools.cached_property` usage. This module was introduced with 2.2.0.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24582: Update providers to use functools compat for ``cached_property``
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24582:
URL: https://github.com/apache/airflow/pull/24582#issuecomment-1161802787
WOOOOHOOO! the benefits of deprecation removals :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #24582: Update providers to use functools compat for ``cached_property``
Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #24582:
URL: https://github.com/apache/airflow/pull/24582#discussion_r903210366
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -14,22 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-import sys
import tempfile
import warnings
from typing import Any, Dict, Generator, List, Optional, Tuple, Union
+from kubernetes import client, config, watch
from kubernetes.config import ConfigException
Review Comment:
Yeah you're right. The import cleanup was a little bit me, but mostly isort. I can't take all the credit 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24582: Update providers to use functools compat for ``cached_property``
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24582:
URL: https://github.com/apache/airflow/pull/24582#discussion_r903592300
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -14,22 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-import sys
import tempfile
import warnings
from typing import Any, Dict, Generator, List, Optional, Tuple, Union
+from kubernetes import client, config, watch
from kubernetes.config import ConfigException
Review Comment:
Shhhh! Don't tell anyone :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on a diff in pull request #24582: Update providers to use functools compat for ``cached_property``
Posted by GitBox <gi...@apache.org>.
blag commented on code in PR #24582:
URL: https://github.com/apache/airflow/pull/24582#discussion_r903149256
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -14,22 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-import sys
import tempfile
import warnings
from typing import Any, Dict, Generator, List, Optional, Tuple, Union
+from kubernetes import client, config, watch
from kubernetes.config import ConfigException
Review Comment:
Ignorable nit: `kubernetes.config` is kinda sorta being imported twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell merged pull request #24582: Update providers to use functools compat for ``cached_property``
Posted by GitBox <gi...@apache.org>.
josh-fell merged PR #24582:
URL: https://github.com/apache/airflow/pull/24582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24582: Update providers to use functools compat for ``cached_property``
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24582:
URL: https://github.com/apache/airflow/pull/24582#issuecomment-1161836358
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org