You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "opwvhk (via GitHub)" <gi...@apache.org> on 2023/02/02 10:36:02 UTC

[GitHub] [avro] opwvhk commented on a diff in pull request #2002: AVRO-3640: [Java] Correctly handle symbolic links as source directory for Maven plugin

opwvhk commented on code in PR #2002:
URL: https://github.com/apache/avro/pull/2002#discussion_r1094341872


##########
lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java:
##########
@@ -202,6 +203,13 @@ public abstract class AbstractAvroMojo extends AbstractMojo {
 
   @Override
   public void execute() throws MojoExecutionException {
+    if (Files.isSymbolicLink(sourceDirectory.toPath())) {

Review Comment:
   The first line below is a null check, but this will throw if sourceDirectory is null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org