[GitHub] [spark] huaxingao commented on a change in pull request #27729: [MINOR][SQL] Remove unnecessary MiMa excludes

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #27729: [MINOR][SQL] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27729#discussion_r385523466
 
 

 ##########
 File path: project/MimaExcludes.scala
 ##########
 @@ -216,14 +216,6 @@ object MimaExcludes {
     ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.regression.RandomForestRegressionModel.setMinInstancesPerNode"),
     ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.regression.RandomForestRegressionModel.setNumTrees"),
 
-    // [SPARK-26124] Update plugins, including MiMa
 
 Review comment:
   
   I think these are not needed any more because of the following was added in https://github.com/apache/spark/pull/23086
   ```
       // Data Source V2 API changes
       (problem: Problem) => problem match {
         case MissingClassProblem(cls) =>
           !cls.fullName.startsWith("org.apache.spark.sql.sources.v2")
         case MissingTypesProblem(newCls, _) =>
           !newCls.fullName.startsWith("org.apache.spark.sql.sources.v2")
         case InheritedNewAbstractMethodProblem(cls, _) =>
           !cls.fullName.startsWith("org.apache.spark.sql.sources.v2")
         case DirectMissingMethodProblem(meth) =>
           !meth.owner.fullName.startsWith("org.apache.spark.sql.sources.v2")
         case ReversedMissingMethodProblem(meth) =>
           !meth.owner.fullName.startsWith("org.apache.spark.sql.sources.v2")
         case _ => true
       }
   ```
   Then, because of https://github.com/apache/spark/pull/25700
   ```
   org.apache.spark.sql.sources.v2.reader -> org.apache.spark.sql.connector.read
   ```
   I think we can actually change the above code to the following
   ```
       (problem: Problem) => problem match {
         case MissingClassProblem(cls) =>
           !cls.fullName.startsWith("org.apache.spark.sql.sources.v2")
         case _ => true
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org