You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/19 06:02:42 UTC
[GitHub] [apisix-dashboard] imjoey opened a new issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
imjoey opened a new issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332
# Feature request
## Please describe your feature
At present, most test cases in Backend E2E and Unit-test cases are using `PUT` method for creating and updating the resource, which leads to extremely low testing coverage for creating by `POST` and updating by `PATCH`.
## Describe the solution you'd like
So it would be much better that if we could add more test cases for the `POST` and `PATCH` methods of the resource. Of course, I would say adding missing test cases is heavy work, so let us fix this gradually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-773785492
issue: #1161
Planned unit test refactoring of ssl,route,upstream,service.
Unit testing of the patch method will be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean closed issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
Jaycean closed issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-769552383
> I hope to help add more test cases.
@Jaycean thanks a lot. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-799413546
@Jaycean could we close this issue now ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-799416728
> @Jaycean could we close this issue now ?
The issue is closed and the test case is complete. If there is any problem, open it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-763530488
Aha! Much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-769550831
@Jaycean Assign to you! Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-773785492
issue: #1161
Planned unit test refactoring of ssl,route,upstream,service.
Unit testing of the patch method will be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1332:
URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-769548154
I hope to help add more test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org