[jira] [Commented] (GUACAMOLE-1525) Support for true fullscreen mode and keyboard lock

["Nick Couchman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484345#comment-17484345 ] 

Nick Couchman commented on GUACAMOLE-1525:
------------------------------------------

[~sirux88]: Thanks for the help and pull request. This actually duplicates two existing Jira issues and some outstanding pull requests:
* GUACAMOLE-124 and https://github.com/apache/guacamole-client/pull/470
* GUACAMOLE-989 and https://github.com/apache/guacamole-client/pull/505

I'd suggest before opening a new pull request for these items that you look at the existing PRs and see if you can offer suggestions/improvement upon those. One of them (keyboard lock) is one I started working on, and I'm certainly not opposed to taking a different direction on it or going with your changes instead of mine, but there's been some discussion on the PR regarding how valuable the changes actually will be. The other pull, for full screen mode, also had quite a bit of discussion on it regarding how it was done.

> Support for true fullscreen mode and keyboard lock
> --------------------------------------------------
>
>                 Key: GUACAMOLE-1525
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1525
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole
>            Reporter: sirux88
>            Priority: Major
>
> As the browser specific fullscreen mode isn't a true fullscreen mode, i made some changes to allow usage of browser fullscreen api ([Fullscreen API - Web APIs | MDN (mozilla.org)|https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API])
> This change works on 
>  
> Futhermore this change allows usage of browser keyboard lock api ([Keyboard.lock() - Web APIs | MDN (mozilla.org)|https://developer.mozilla.org/en-US/docs/Web/API/Keyboard/lock]) to prevent execution of special keys on local (eg. Meta key, Functionkeys with special browser purpose like F5 oder F11)
> Unfortunately keyboard lock api only works on chromium based browsers



--
This message was sent by Atlassian Jira
(v8.20.1#820001)