You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Justin Erenkrantz <ju...@erenkrantz.com> on 2005/08/11 19:19:12 UTC

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

--On August 10, 2005 11:36:43 PM +0000 niq@apache.org wrote:

> Author: niq
> Date: Wed Aug 10 16:36:39 2005
> New Revision: 231355
>
> URL: http://svn.apache.org/viewcvs?rev=231355&view=rev
> Log:
> Fix ProxyPassReverse & family to work correctly in <Location>

This commit broke the build.

/Users/jerenk/work/httpd-2.3/modules/proxy/mod_proxy.c: In function 
'merge_proxy_dir_config':
/Users/jerenk/work/httpd-2.3/modules/proxy/mod_proxy.c:880: error: 'base' 
undeclared (first use in this function)
/Users/jerenk/work/httpd-2.3/modules/proxy/mod_proxy.c:880: error: (Each 
undeclared identifier is reported only once
/Users/jerenk/work/httpd-2.3/modules/proxy/mod_proxy.c:880: error: for each 
function it appears in.)
/Users/jerenk/work/httpd-2.3/modules/proxy/mod_proxy.c:880: error: 'overrides' 
undeclared (first use in this function)

Please fix or revert.  (I have no idea what you were trying to do.)  -- justin

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

Posted by Nick Kew <ni...@webthing.com>.
Joe Orton wrote:

> plus this looks equally broken:

OK, I've bitten the bullet and updated my build environment here to
to build the whole proxy in context.  Apologies for assuming this
fix was too simple to need it.

Note that the 2.0 fix is a straight diff between 2.0.54 and a fully
working fixed version.  That's basically what I was copying from, but
I hadn't appreciated how widespread *relevant* changes had become.

-- 
Nick Kew

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

Posted by Joe Orton <jo...@redhat.com>.
On Fri, Aug 12, 2005 at 07:59:49AM +0100, Joe Orton wrote:
> On Thu, Aug 11, 2005 at 07:56:38PM +0100, Nick Kew wrote:
> > Justin Erenkrantz wrote:
> > 
> > >>Fix ProxyPassReverse & family to work correctly in <Location>
> > >
> > >
> > >This commit broke the build.
> > 
> > Aaargh!  Careless cut&paste.  Sorry.  Fixed - thanks.
> 
> proxy_util.c: In function `ap_proxy_location_reverse_map':
> proxy_util.c:1015: error: structure has no member named `raliases'
> proxy_util.c:1016: error: structure has no member named `raliases'

plus this looks equally broken:

mod_proxy_http.c: In function 'process_proxy_header':
mod_proxy_http.c:998: warning: passing argument 2 of 'transform_hdrs[i].func' from incompatible pointer type

joe

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

Posted by Joe Orton <jo...@redhat.com>.
On Thu, Aug 11, 2005 at 07:56:38PM +0100, Nick Kew wrote:
> Justin Erenkrantz wrote:
> 
> >>Fix ProxyPassReverse & family to work correctly in <Location>
> >
> >
> >This commit broke the build.
> 
> Aaargh!  Careless cut&paste.  Sorry.  Fixed - thanks.

proxy_util.c: In function `ap_proxy_location_reverse_map':
proxy_util.c:1015: error: structure has no member named `raliases'
proxy_util.c:1016: error: structure has no member named `raliases'
proxy_util.c: In function `ap_proxy_cookie_reverse_map':
proxy_util.c:1053: error: structure has no member named `cookie_path_str'
proxy_util.c:1053: error: structure has no member named `cookie_path_str'
proxy_util.c:1053: warning: left-hand operand of comma expression has no effect
proxy_util.c:1059: error: structure has no member named `cookie_paths'
proxy_util.c:1060: error: structure has no member named `cookie_paths'
proxy_util.c:1070: error: structure has no member named `cookie_domain_str'
proxy_util.c:1070: error: structure has no member named `cookie_domain_str'
proxy_util.c:1070: warning: left-hand operand of comma expression has no effect
proxy_util.c:1076: error: structure has no member named `cookie_domains'
proxy_util.c:1077: error: structure has no member named `cookie_domains'

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

Posted by Nick Kew <ni...@webthing.com>.
Justin Erenkrantz wrote:

>> Fix ProxyPassReverse & family to work correctly in <Location>
> 
> 
> This commit broke the build.

Aaargh!  Careless cut&paste.  Sorry.  Fixed - thanks.

> Please fix or revert.  (I have no idea what you were trying to do.)  -- 

See my posts on "Fixing ProxyPassReverse".

-- 
Nick Kew