You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/04/25 21:15:52 UTC

[GitHub] [jena] acoburn commented on pull request #731: JENA-1888: Exclude log4j2 from OSGi bundle

acoburn commented on pull request #731:
URL: https://github.com/apache/jena/pull/731#issuecomment-619441709


   I spent some time familiarizing myself with the log4j2 code dependency in jena-base. Because log4j-api and log4j-core are marked as optional in that module's pom.xml (and given how the code is structured in LogCtl.java), it seems more correct for those OSGi imports to be marked as optional. To me, this seems like a better solution than excluding the imports; plus, it mirrors the dependency structure of jena-base itself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org