You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2016/09/21 23:23:02 UTC
[GitHub] nifi-minifi pull request #38: MINIFI-86 Adding explicit checks for any unsup...
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/38
MINIFI-86 Adding explicit checks for any unsupported components when t\u2026
\u2026transforming a template
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-86
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 87dafae0f4675b360feb724bfb1a7038971699b0
Author: Joseph Percivall <jo...@yahoo.com>
Date: 2016-09-21T23:22:38Z
MINIFI-86 Adding explicit checks for any unsupported components when transforming a template
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #38: MINIFI-86 Adding explicit checks for any unsup...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/38#discussion_r80093463
--- Diff: minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java ---
@@ -251,6 +268,10 @@ public int transform(String[] args) {
System.out.println();
printTransformUsage();
return ERR_UNABLE_TO_TRANFORM_TEMPLATE;
--- End diff --
realize this is already existing, but perhaps we should adjust to correct spelling error while in this code area
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #38: MINIFI-86 Adding explicit checks for any unsup...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/38#discussion_r80092383
--- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/resources/TemplateWithFunnel.xml ---
@@ -0,0 +1 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?><template><description></description><name>TemplateWithFunnel</name><snippet><funnels><id>e2c5b2f0-6740-4d57-a40b-20b27da784a3</id><parentGroupId>5e4f1cc2-78e9-4e08-a0c2-11779c9efc17</parentGroupId><position><x>2268.1912159884546</x><y>695.3930796314235</y></position></funnels></snippet><timestamp>09/21/2016 19:08:15 EDT</timestamp></template>
--- End diff --
This and the other three test resources should have the license header. RAT is currently failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #38: MINIFI-86 Adding explicit checks for any unsup...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #38: MINIFI-86 Adding explicit checks for any unsup...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/38#discussion_r80093282
--- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMainTest.java ---
@@ -173,6 +174,46 @@ public void testTransformRoundTripStressTestFramework() throws IOException, JAXB
transformRoundTrip("StressTestFramework");
}
+ @Test
--- End diff --
if anticipating a exception, should likely use the @Test(expected = ) in lieu of the try-catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---