You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/01 05:48:37 UTC
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5735: [VMware] Improve volume file search on the datastore while computing the VM snapshot chain size.
sureshanaparti commented on a change in pull request #5735:
URL: https://github.com/apache/cloudstack/pull/5735#discussion_r759871333
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##########
@@ -1306,12 +1307,12 @@ private void setVolumeToPathAndSize(List<VolumeObjectTO> volumeTOs, Map<String,
// get volume's chain size for this VM snapshot; exclude current volume vdisk
DataStoreTO store = volumeTO.getDataStore();
ManagedObjectReference morDs = getDatastoreAsManagedObjectReference(baseName, hyperHost, store);
- long size = getVMSnapshotChainSize(context, hyperHost, baseName + ".vmdk", morDs, newPath);
- size = getVMSnapshotChainSize(context, hyperHost, baseName + "-*.vmdk", morDs, newPath);
+ long size = getVMSnapshotChainSize(context, hyperHost, baseName + ".vmdk", morDs, newPath, vmName);
Review comment:
yes @Pearl1594, already created a separate PR (https://github.com/apache/cloudstack/pull/5720).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org