You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2017/05/23 18:18:02 UTC
[03/16] beam git commit: Remove unused StepContext name methods
Remove unused StepContext name methods
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/acce24ce
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/acce24ce
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/acce24ce
Branch: refs/heads/master
Commit: acce24ce1388b7953fbb9d87da5bb2271286c58a
Parents: 97c230a
Author: Kenneth Knowles <kl...@google.com>
Authored: Mon May 22 17:42:10 2017 -0700
Committer: Kenneth Knowles <kl...@google.com>
Committed: Tue May 23 11:16:27 2017 -0700
----------------------------------------------------------------------
.../runners/apex/translation/utils/NoOpStepContext.java | 10 ----------
.../org/apache/beam/runners/core/BaseStepContext.java | 10 ----------
.../java/org/apache/beam/runners/core/StepContext.java | 10 ----------
.../beam/runners/direct/DirectExecutionContext.java | 10 ----------
.../flink/translation/functions/FlinkNoOpStepContext.java | 10 ----------
.../translation/wrappers/streaming/DoFnOperator.java | 10 ----------
.../runners/spark/translation/SparkProcessContext.java | 9 ---------
.../org/apache/beam/fn/harness/fake/FakeStepContext.java | 9 ---------
8 files changed, 78 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/runners/apex/src/main/java/org/apache/beam/runners/apex/translation/utils/NoOpStepContext.java
----------------------------------------------------------------------
diff --git a/runners/apex/src/main/java/org/apache/beam/runners/apex/translation/utils/NoOpStepContext.java b/runners/apex/src/main/java/org/apache/beam/runners/apex/translation/utils/NoOpStepContext.java
index 820b189..b49e4da 100644
--- a/runners/apex/src/main/java/org/apache/beam/runners/apex/translation/utils/NoOpStepContext.java
+++ b/runners/apex/src/main/java/org/apache/beam/runners/apex/translation/utils/NoOpStepContext.java
@@ -29,16 +29,6 @@ public class NoOpStepContext implements StepContext, Serializable {
private static final long serialVersionUID = 1L;
@Override
- public String getStepName() {
- return null;
- }
-
- @Override
- public String getTransformName() {
- return null;
- }
-
- @Override
public StateInternals stateInternals() {
return null;
}
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java
----------------------------------------------------------------------
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java
index e639c46..4abd4d2 100644
--- a/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java
+++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java
@@ -33,16 +33,6 @@ public abstract class BaseStepContext implements StepContext {
}
@Override
- public String getStepName() {
- return stepName;
- }
-
- @Override
- public String getTransformName() {
- return transformName;
- }
-
- @Override
public abstract StateInternals stateInternals();
@Override
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/runners/core-java/src/main/java/org/apache/beam/runners/core/StepContext.java
----------------------------------------------------------------------
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/StepContext.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/StepContext.java
index 62a81f1..60fc402 100644
--- a/runners/core-java/src/main/java/org/apache/beam/runners/core/StepContext.java
+++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/StepContext.java
@@ -22,16 +22,6 @@ package org.apache.beam.runners.core;
*/
public interface StepContext {
- /**
- * The name of the step.
- */
- String getStepName();
-
- /**
- * The name of the transform for the step.
- */
- String getTransformName();
-
StateInternals stateInternals();
TimerInternals timerInternals();
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java
----------------------------------------------------------------------
diff --git a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java
index 05dbebc..651af8f 100644
--- a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java
+++ b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java
@@ -121,16 +121,6 @@ class DirectExecutionContext {
return null;
}
- @Override
- public String getStepName() {
- return stepName;
- }
-
- @Override
- public String getTransformName() {
- return transformName;
- }
-
/**
* Gets the timer update of the {@link TimerInternals} of this {@link DirectStepContext},
* which is empty if the {@link TimerInternals} were never accessed.
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkNoOpStepContext.java
----------------------------------------------------------------------
diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkNoOpStepContext.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkNoOpStepContext.java
index 1ff322e..9c7b636 100644
--- a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkNoOpStepContext.java
+++ b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkNoOpStepContext.java
@@ -27,16 +27,6 @@ import org.apache.beam.runners.core.TimerInternals;
public class FlinkNoOpStepContext implements StepContext {
@Override
- public String getStepName() {
- return null;
- }
-
- @Override
- public String getTransformName() {
- return null;
- }
-
- @Override
public StateInternals stateInternals() {
return null;
}
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
----------------------------------------------------------------------
diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
index 4f8998e..d2ab7e1 100644
--- a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
+++ b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
@@ -677,16 +677,6 @@ public class DoFnOperator<InputT, FnOutputT, OutputT>
protected class StepContext implements org.apache.beam.runners.core.StepContext {
@Override
- public String getStepName() {
- return null;
- }
-
- @Override
- public String getTransformName() {
- return null;
- }
-
- @Override
public StateInternals stateInternals() {
return stateInternals;
}
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkProcessContext.java
----------------------------------------------------------------------
diff --git a/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkProcessContext.java b/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkProcessContext.java
index e693143..f4ab7d9 100644
--- a/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkProcessContext.java
+++ b/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkProcessContext.java
@@ -95,15 +95,6 @@ class SparkProcessContext<FnInputT, FnOutputT, OutputT> {
}
static class NoOpStepContext implements StepContext {
- @Override
- public String getStepName() {
- return null;
- }
-
- @Override
- public String getTransformName() {
- return null;
- }
@Override
public StateInternals stateInternals() {
http://git-wip-us.apache.org/repos/asf/beam/blob/acce24ce/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/fake/FakeStepContext.java
----------------------------------------------------------------------
diff --git a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/fake/FakeStepContext.java b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/fake/FakeStepContext.java
index 3f6a2da..bdf138b 100644
--- a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/fake/FakeStepContext.java
+++ b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/fake/FakeStepContext.java
@@ -26,15 +26,6 @@ import org.apache.beam.runners.core.TimerInternals;
* A fake {@link StepContext} factory that performs no-ops.
*/
public class FakeStepContext implements StepContext {
- @Override
- public String getStepName() {
- return "TODO";
- }
-
- @Override
- public String getTransformName() {
- return "TODO";
- }
@Override
public StateInternals stateInternals() {