[GitHub] [incubator-livy] jinhaichen commented on a diff in pull request #249: [LIVY-702]: Submit Spark apps to Kubernetes

["jinhaichen (via GitHub)" <gi...@apache.org>]

jinhaichen commented on code in PR #249:
URL: https://github.com/apache/incubator-livy/pull/249#discussion_r1136699910


##########
rsc/src/main/java/org/apache/livy/rsc/RSCConf.java:
##########
@@ -151,6 +152,12 @@ public String findLocalAddress() throws IOException {
     return address.getCanonicalHostName();
   }
 
+  public boolean isRunningOnKubernetes() {
+    return Optional.ofNullable(get("livy.spark.master"))
+            .filter(s -> s.startsWith("k8s"))
+            .isPresent();
+  }
+

Review Comment:
   this function may always return false, since "livy.spark.master" will not get by RSCConf



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org