You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by rojopolis <gi...@git.apache.org> on 2018/07/03 03:23:11 UTC

[GitHub] libcloud pull request #1223: [LIBCLOUD-1002] Add instance template support t...

GitHub user rojopolis opened a pull request:

    https://github.com/apache/libcloud/pull/1223

    [LIBCLOUD-1002] Add instance template support to GCE create_node

    ## Instance template support for GCE create_node
    
    ### Allows Nodes to be created from GCE Instance Templates
    
    This change allows Nodes to be created from predefined Instance Templates in GCE.  
    This is useful in a number of scenarios:
    * Organizational standards are implemented with Templates.
    * etc.
    
    The attributes specified in the call to create_node will take precedence over those defined in the template (per provider documentation).
    
    #### Provider docs: 
    - https://cloud.google.com/compute/docs/reference/rest/v1/instances/insert
    - https://cloud.google.com/compute/docs/instances/create-vm-from-instance-template
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rojopolis/libcloud LIBCLOUD-1002_gce_instance_template

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1223
    
----
commit 271aff59636f7f1dd9764ba39753fd5c1c4b3f27
Author: Robert Jordan <rj...@...>
Date:   2018-07-03T03:21:22Z

    [LIBCLOUD-1002] Add instance template support to GCE create_node

----


---