You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Andras Piros (JIRA)" <ji...@apache.org> on 2017/09/21 05:51:00 UTC

[jira] [Comment Edited] (OOZIE-2885) Running Spark actions should not need Hive on the classpath

    [ https://issues.apache.org/jira/browse/OOZIE-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174303#comment-16174303 ] 

Andras Piros edited comment on OOZIE-2885 at 9/21/17 5:50 AM:
--------------------------------------------------------------

[~satishsaley] thanks for the contribution! Please extract the code in the {{try-catch}} block to a method w/ a describing name, and add a unit test to [*{{TestSparkMain}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java] and / or [*{{TestSparkArgsExtractor}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java] and / or [*{{TestSparkOptionsSplitter}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkOptionsSplitter.java] to have better coverage and to document why this change is needed.


was (Author: andras.piros):
[~satishsaley] thanks for the contribution! Please extract the code in the {{try-catch}} block to a method w/ a describing name, add a unit test to [*{{TestSparkMain}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java] and / or [*{{TestSparkArgsExtractor}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java] and / or [*{{TestSparkOptionsSplitter}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkOptionsSplitter.java] to have better coverage and to document why this change is needed.

> Running Spark actions should not need Hive on the classpath
> -----------------------------------------------------------
>
>                 Key: OOZIE-2885
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2885
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Peter Cseh
>            Assignee: Satish Subhashrao Saley
>            Priority: Critical
>         Attachments: OOZIE-2885-1.patch
>
>
> SparkMain references HiveConf so we need hive-common jar on the classpath even if the Spark job has nothing to do with Hive. 
> This shouldn't be the case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)