You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <av...@gmail.com> on 2012/09/27 07:32:54 UTC
Review Request: GIRAPH-328.5
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/
-----------------------------------------------------------
Review request for giraph.
Description
-------
Review of Eli's GIRAPH-328.5.patch. Reviewboard helps me to be more precise about my comments.
Diffs
-----
src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712
src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java f3a8d4f
src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692
src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2
src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435
src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION
src/main/java/org/apache/giraph/graph/BspServiceMaster.java 18b5387
src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87
src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f
src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2
Diff: https://reviews.apache.org/r/7308/diff/
Testing
-------
mvn clean verify
Thanks,
Avery Ching
Re: Review Request: GIRAPH-328.5
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/
-----------------------------------------------------------
(Updated Sept. 30, 2012, 4:42 a.m.)
Review request for giraph.
Description
-------
Review of Eli's GIRAPH-328.5.patch. Reviewboard helps me to be more precise about my comments.
This addresses bug GIRAPH-328.
https://issues.apache.org/jira/browse/GIRAPH-328
Diffs
-----
src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712
src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 126b18e
src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692
src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2
src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435
src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION
src/main/java/org/apache/giraph/graph/BspServiceMaster.java 6edd31e
src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87
src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f
src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2
Diff: https://reviews.apache.org/r/7308/diff/
Testing
-------
mvn clean verify
Thanks,
Avery Ching
Re: Review Request: GIRAPH-328.5
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/
-----------------------------------------------------------
(Updated Sept. 30, 2012, 4:42 a.m.)
Review request for giraph.
Changes
-------
Here is a fixed version that passes the unittests and worked on a test of an app on 100 workers.
Description
-------
Review of Eli's GIRAPH-328.5.patch. Reviewboard helps me to be more precise about my comments.
Diffs (updated)
-----
src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712
src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 126b18e
src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692
src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2
src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435
src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION
src/main/java/org/apache/giraph/graph/BspServiceMaster.java 6edd31e
src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87
src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f
src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2
Diff: https://reviews.apache.org/r/7308/diff/
Testing
-------
mvn clean verify
Thanks,
Avery Ching
Re: Review Request: GIRAPH-328.5
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/#review12044
-----------------------------------------------------------
This is close Eli, I'm noted a few things. I'll be submitting a fixed diff for you. Let me know what you think and we can commit your good work!
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25669>
This comment is a bit strangely worded. Perhaps something like
// Only cache the valid partition ids
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25670>
getInetSocketAddress -> resolveAddress
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25671>
getInetSocketAddress -> resolveAddress
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25672>
getInetSocketAddress -> resolveAddress
- Avery Ching
On Sept. 29, 2012, 4:39 p.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7308/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2012, 4:39 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> Review of Eli's GIRAPH-328.5.patch. Reviewboard helps me to be more precise about my comments.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712
> src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c
> src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 126b18e
> src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692
> src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2
> src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435
> src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION
> src/main/java/org/apache/giraph/graph/BspServiceMaster.java 6edd31e
> src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87
> src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f
> src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2
>
> Diff: https://reviews.apache.org/r/7308/diff/
>
>
> Testing
> -------
>
> mvn clean verify
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: GIRAPH-328.5
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/
-----------------------------------------------------------
(Updated Sept. 29, 2012, 4:39 p.m.)
Review request for giraph.
Changes
-------
Added Eli's new 328-7 patch.
Description
-------
Review of Eli's GIRAPH-328.5.patch. Reviewboard helps me to be more precise about my comments.
Diffs (updated)
-----
src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712
src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 126b18e
src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692
src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2
src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435
src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION
src/main/java/org/apache/giraph/graph/BspServiceMaster.java 6edd31e
src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87
src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f
src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2
Diff: https://reviews.apache.org/r/7308/diff/
Testing
-------
mvn clean verify
Thanks,
Avery Ching
Re: Review Request: GIRAPH-328.5
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7308/#review11964
-----------------------------------------------------------
src/main/java/org/apache/giraph/comm/SendMessageCache.java
<https://reviews.apache.org/r/7308/#comment25497>
Would be nice to change this to
"for all workers"
src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java
<https://reviews.apache.org/r/7308/#comment25498>
Thank you for fixing this!
src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java
<https://reviews.apache.org/r/7308/#comment25499>
Good catch!
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25500>
I see what you are doing, but couldn't we instead have another method
getInetSocketAddress(WorkerInfo workerInfo)
that does this instead of sending in an unexpected partition id? This seems a little hacky.
At the very least, we should modify the javadoc for @param partitionId to reflect that we do expect USE_WORKERINFO_ADDRESS in some cases.
src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/7308/#comment25502>
This could just use the new method getInetSocketAddress(entry.getKey) I suggested earlier.
src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java
<https://reviews.apache.org/r/7308/#comment25505>
Please remove.
src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java
<https://reviews.apache.org/r/7308/#comment25503>
getConf().createVertexId() instead please, shouldn't use BspUtils anymore.
src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java
<https://reviews.apache.org/r/7308/#comment25504>
Please no BspUtils.
src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java
<https://reviews.apache.org/r/7308/#comment25506>
Messages sent for one or more partitions?
- Avery Ching
On Sept. 27, 2012, 5:32 a.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7308/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2012, 5:32 a.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> Review of Eli's GIRAPH-328.5.patch. Reviewboard helps me to be more precise about my comments.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/giraph/comm/SendMessageCache.java 3d38712
> src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java ce0e64c
> src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java f3a8d4f
> src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692
> src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java 7cae1e2
> src/main/java/org/apache/giraph/comm/requests/SendPartitionMessagesRequest.java 1b3a435
> src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java PRE-CREATION
> src/main/java/org/apache/giraph/graph/BspServiceMaster.java 18b5387
> src/main/java/org/apache/giraph/graph/WorkerInfo.java 0224d87
> src/test/java/org/apache/giraph/comm/RequestFailureTest.java 02f699f
> src/test/java/org/apache/giraph/comm/RequestTest.java aa0ddd2
>
> Diff: https://reviews.apache.org/r/7308/diff/
>
>
> Testing
> -------
>
> mvn clean verify
>
>
> Thanks,
>
> Avery Ching
>
>