You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/30 18:07:15 UTC
[GitHub] [airflow] avkirilishin opened a new pull request #21227: Allow list item to be rendered instead of showing as JSON
avkirilishin opened a new pull request #21227:
URL: https://github.com/apache/airflow/pull/21227
closes: #13988
related: #17321
related: #11177
#17321 broke a list item rendering that was introduced in #14024.
This PR fixes it again and adds some tests to avoid problems in the future.
Impact on operators:
| Operator | Before PR | After |
| - | ------------- | ------------- |
| VerticaOperator | <img width="200" alt="image" src="https://user-images.githubusercontent.com/54231417/151705247-5c51e970-39c8-4f5f-8991-9df4edf13f47.png">| <img width="200" alt="image" src="https://user-images.githubusercontent.com/54231417/151705279-6be38e5b-b5f7-4a50-9765-dc3695955377.png"> |
| PythonOperator | <img width="562" alt="image" src="https://user-images.githubusercontent.com/54231417/151705503-63edd4cb-9b82-4466-a201-e07d5eb37008.png"> | <img width="555" alt="image" src="https://user-images.githubusercontent.com/54231417/151705515-696bf584-5baf-4dcb-b714-87cb7c730793.png"> |
| TaskFlow | <img width="448" alt="image" src="https://user-images.githubusercontent.com/54231417/151705466-cee94704-25f7-49ff-a97f-f52e7dafcd68.png"> | <img width="444" alt="image" src="https://user-images.githubusercontent.com/54231417/151705478-b06a250e-ad8d-4b24-a2f6-8cec1a0997b6.png"> |
| SimpleHttpOperator | <img width="461" alt="image" src="https://user-images.githubusercontent.com/54231417/151705434-78326711-b49b-48f6-b29c-b47b15302655.png"> | <img width="461" alt="image" src="https://user-images.githubusercontent.com/54231417/151705444-18e48da9-8f8d-43d9-b234-57df0f53db0d.png"> |
| BigQueryInsertJobOperator | <img width="724" alt="image" src="https://user-images.githubusercontent.com/54231417/151705530-2cbd6f0a-2fd4-4f7a-9d28-22a8202988b1.png"> | <img width="721" alt="image" src="https://user-images.githubusercontent.com/54231417/151705542-6e2de27b-3202-4307-9c56-d4581a89933b.png"> |
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] avkirilishin commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
avkirilishin commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1026037170
> What changed in BigQueryInsertJobOperator? The two images look the same to me.
Yes, they are the same. Nothing changed in BigQueryInsertJobOperator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1026038583
I guess my question is, why are the screenshots attached if nothing changes there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1071888818
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1071888818
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] peloyeje commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
peloyeje commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1073998334
Hi, first of all thanks for the fix! What is the expected timeframe to see this one merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1025460082
What changed in `BigQueryInsertJobOperator`? The two images look the same to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] avkirilishin commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
avkirilishin commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1026040634
To emphasize that the functionality from #17321 is not broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1026045692
I see, thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21227: Allow list item to be rendered instead of showing as JSON
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21227:
URL: https://github.com/apache/airflow/pull/21227#issuecomment-1079956484
@peloyeje I guess it will be there as soon as the author (@avkirilishin ) rebaases it and fixes the static checks that were failing. Or if the author does not do it, maybe someone (you @peloyeje ) take it over and lead it to completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org