You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/25 19:07:19 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6579: NIFI-10697 Refactor nifi-toolkit tests to use JUnit 5

exceptionfactory opened a new pull request, #6579:
URL: https://github.com/apache/nifi/pull/6579

   # Summary
   
   [NIFI-10697](https://issues.apache.org/jira/browse/NIFI-10697) Refactors unit tests in `nifi-toolkit` modules using JUnit 5. 
   
   All tests use JUnit 5 Jupiter components, with the exception of `ConfigEncryptionToolTest`, which is written in Groovy and contains a very large number of methods that should be handled in a separate issue. Aside from general replacement, particular changes include removing the `RegistryManualIT`, which is not executed in automated builds, and streamlining `EncryptConfigMainTest` to avoid methods that are duplicative of `ConfigEncryptionToolTest`.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 closed pull request #6579: NIFI-10697 Refactor nifi-toolkit tests to use JUnit 5

Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6579: NIFI-10697 Refactor nifi-toolkit tests to use JUnit 5
URL: https://github.com/apache/nifi/pull/6579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #6579: NIFI-10697 Refactor nifi-toolkit tests to use JUnit 5

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6579:
URL: https://github.com/apache/nifi/pull/6579#issuecomment-1291031393

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #6579: NIFI-10697 Refactor nifi-toolkit tests to use JUnit 5

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6579:
URL: https://github.com/apache/nifi/pull/6579#issuecomment-1292168393

   +1 LGTM, thanks for the improvements! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org