You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2022/10/28 20:48:15 UTC

[GitHub] [shiro] bdemers opened a new pull request, #518: Allow for direct configuration of ShiroFilter through WebEnvironment

bdemers opened a new pull request, #518:
URL: https://github.com/apache/shiro/pull/518

   Adds new ShiroFilterConfiguration class exposed through the WebEnvironment
   This class allows for confiuration of the Shiro filter through various config mechanisms (Ini, Guice, Spring, etc)
   This makes it easer to enable a static security manager when using Shiro's Servlet fragment, as now a web.xml is not required
   
   Backport: 28e10e0ca1cdcd2cede86802fde8464b29265fc8
   
   <!--
   For Security Vulnerabilities, please email: security@shiro.apache.org
   For more details on how to report a vulnerablity see: https://www.apache.org/security/
   -->
   
   Following this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SHIRO) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SHIRO-XXX] - Fixes bug in SessionManager`,
          where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. 
    
   Trivial changes like typos do not require a JIRA issue (javadoc, comments...). 
   In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
    
   If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
   
   If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) 
   if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] bmarwell merged pull request #518: Allow for direct configuration of ShiroFilter through WebEnvironment

Posted by GitBox <gi...@apache.org>.
bmarwell merged PR #518:
URL: https://github.com/apache/shiro/pull/518


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] bdemers commented on pull request #518: Allow for direct configuration of ShiroFilter through WebEnvironment

Posted by GitBox <gi...@apache.org>.
bdemers commented on PR #518:
URL: https://github.com/apache/shiro/pull/518#issuecomment-1295461679

   This should wait for #519 to be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] bdemers commented on pull request #518: Allow for direct configuration of ShiroFilter through WebEnvironment

Posted by GitBox <gi...@apache.org>.
bdemers commented on PR #518:
URL: https://github.com/apache/shiro/pull/518#issuecomment-1298818908

   Fixed imports.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] bmarwell commented on a diff in pull request #518: Allow for direct configuration of ShiroFilter through WebEnvironment

Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #518:
URL: https://github.com/apache/shiro/pull/518#discussion_r1010601909


##########
support/guice/src/test/java/org/apache/shiro/guice/web/GuiceShiroFilterTest.java:
##########
@@ -19,13 +19,13 @@
 package org.apache.shiro.guice.web;
 
 import com.google.inject.spi.InjectionPoint;
+import org.apache.shiro.web.config.ShiroFilterConfiguration;
 import org.apache.shiro.web.filter.mgt.FilterChainResolver;
 import org.apache.shiro.web.mgt.WebSecurityManager;
 import org.junit.Test;
 
-import static org.easymock.EasyMock.createMock;
-import static org.junit.Assert.assertSame;
-import static org.junit.Assert.fail;
+import static org.easymock.EasyMock.*;

Review Comment:
   Please revert to explicit imports.



##########
web/src/main/java/org/apache/shiro/web/servlet/ShiroFilter.java:
##########
@@ -70,8 +70,10 @@ public class ShiroFilter extends AbstractShiroFilter {
      */
     @Override
     public void init() throws Exception {
+

Review Comment:
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org