You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/04/29 01:58:55 UTC
Review Request 46806: Fixed and illustrated process::initialize
ordering.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and Kapil Arya.
Bugs: MESOS-5304
https://issues.apache.org/jira/browse/MESOS-5304
Repository: mesos
Description
-------
Moves `metrics::initialize` below the creation of the `help` process.
Adds a comment block to explain the ordering of process creation in
`process::initialize`.
Diffs
-----
3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c
Diff: https://reviews.apache.org/r/46806/diff/
Testing
-------
make check
Also double-checked that `/help/metrics/snapshot` shows up on both master and agent.
Thanks,
Joseph Wu
Re: Review Request 46806: Fixed and illustrated process::initialize
ordering.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/#review131069
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/process.cpp (line 976)
<https://reviews.apache.org/r/46806/#comment195023>
2 spaces before 'The'
3rdparty/libprocess/src/process.cpp (line 979)
<https://reviews.apache.org/r/46806/#comment195025>
the second 'the same group' feels a bit redundant, but not a real issue
- Joerg Schad
On April 28, 2016, 11:58 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46806/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:58 p.m.)
>
>
> Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and Kapil Arya.
>
>
> Bugs: MESOS-5304
> https://issues.apache.org/jira/browse/MESOS-5304
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves `metrics::initialize` below the creation of the `help` process.
>
> Adds a comment block to explain the ordering of process creation in
> `process::initialize`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c
>
> Diff: https://reviews.apache.org/r/46806/diff/
>
>
> Testing
> -------
>
> make check
>
> Also double-checked that `/help/metrics/snapshot` shows up on both master and agent.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 46806: Fixed and illustrated process::initialize
ordering.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/#review131036
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On April 28, 2016, 11:58 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46806/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:58 p.m.)
>
>
> Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and Kapil Arya.
>
>
> Bugs: MESOS-5304
> https://issues.apache.org/jira/browse/MESOS-5304
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves `metrics::initialize` below the creation of the `help` process.
>
> Adds a comment block to explain the ordering of process creation in
> `process::initialize`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c
>
> Diff: https://reviews.apache.org/r/46806/diff/
>
>
> Testing
> -------
>
> make check
>
> Also double-checked that `/help/metrics/snapshot` shows up on both master and agent.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 46806: Fixed and illustrated process::initialize
ordering.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/#review131120
-----------------------------------------------------------
Fix it, then Ship it!
Thanks Joseph! LGTM, modulo Joerg's comments and another small one below.
3rdparty/libprocess/src/process.cpp (line 989)
<https://reviews.apache.org/r/46806/#comment195064>
I'm guessing this refers to `new Route("/__processes__", None(), __processes__);`? I think it might be helpful to use a more obvious name. Or perhaps referencing the `process_route` name in a comment above the `Route()` statement would do the trick?
- Greg Mann
On April 28, 2016, 11:58 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46806/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:58 p.m.)
>
>
> Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and Kapil Arya.
>
>
> Bugs: MESOS-5304
> https://issues.apache.org/jira/browse/MESOS-5304
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves `metrics::initialize` below the creation of the `help` process.
>
> Adds a comment block to explain the ordering of process creation in
> `process::initialize`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c
>
> Diff: https://reviews.apache.org/r/46806/diff/
>
>
> Testing
> -------
>
> make check
>
> Also double-checked that `/help/metrics/snapshot` shows up on both master and agent.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 46806: Fixed and illustrated process::initialize
ordering.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/#review131039
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46806]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 28, 2016, 11:58 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46806/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:58 p.m.)
>
>
> Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and Kapil Arya.
>
>
> Bugs: MESOS-5304
> https://issues.apache.org/jira/browse/MESOS-5304
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves `metrics::initialize` below the creation of the `help` process.
>
> Adds a comment block to explain the ordering of process creation in
> `process::initialize`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c
>
> Diff: https://reviews.apache.org/r/46806/diff/
>
>
> Testing
> -------
>
> make check
>
> Also double-checked that `/help/metrics/snapshot` shows up on both master and agent.
>
>
> Thanks,
>
> Joseph Wu
>
>