You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/26 10:34:24 UTC
[GitHub] [flink-statefun] tzulitai opened a new pull request #37:
[FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
tzulitai opened a new pull request #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37
This PR is based on 2 other PRs:
- #36 which adds the new routable Kafka ingress, and
- #35 which adds some functionality to the `StatefulFunctionsAppContainers` which this new E2E in this PR will depend on.
Only commits after a6a8855 are relevant (4 in total).
---
### Changelog description
- a6a8855 Adds a new `*-e2e` module for the new E2E test.
- ef3b31f Adds the verification application to test against. Please see Javadoc of `RoutableKafkaVerificationModule` on what it does.
- e0c2b1d A preliminary addition to `StatefulFunctionsAppContainers` that allows the E2E to add YAML module definitions to be added to the application image build context.
- 652b132 Adds the actual E2E test. See Javadoc of `RoutableKafkaE2E` on how it verifies the ingress' functionality.
---
### Verifying
Run `mvn clean verify -Prun-e2e-tests` to run the E2E test (or in the IDE).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai edited a comment on issue #37:
[FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
Posted by GitBox <gi...@apache.org>.
tzulitai edited a comment on issue #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37#issuecomment-593795750
Thanks! Merging ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on issue #37: [FLINK-16123] Add
E2E for auto-routable Protobuf Kafka ingress
Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37#issuecomment-592853509
@igalshilman I've rebased this on the latest master after merging #35.
Would you want to take a look at this as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai closed pull request #37: [FLINK-16123]
Add E2E for auto-routable Protobuf Kafka ingress
Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai closed pull request #37: [FLINK-16123]
Add E2E for auto-routable Protobuf Kafka ingress
Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] igalshilman commented on issue #37: [FLINK-16123]
Add E2E for auto-routable Protobuf Kafka ingress
Posted by GitBox <gi...@apache.org>.
igalshilman commented on issue #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37#issuecomment-593773473
Let’s merge it, so it won’t diverge too much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on issue #37: [FLINK-16123] Add
E2E for auto-routable Protobuf Kafka ingress
Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37#issuecomment-593795750
Thanks, merging ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai opened a new pull request #37:
[FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
Posted by GitBox <gi...@apache.org>.
tzulitai opened a new pull request #37: [FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/37
This PR is based on 2 other PRs:
- #36 which adds the new routable Kafka ingress, and
- #35 which adds some functionality to the `StatefulFunctionsAppContainers` which this new E2E in this PR will depend on.
Only commits after a6a8855 are relevant (4 in total).
---
### Changelog description
- a6a8855 Adds a new `*-e2e` module for the new E2E test.
- ef3b31f Adds the verification application to test against. Please see Javadoc of `RoutableKafkaVerificationModule` on what it does.
- e0c2b1d A preliminary addition to `StatefulFunctionsAppContainers` that allows the E2E to add YAML module definitions to be added to the application image build context.
- 652b132 Adds the actual E2E test. See Javadoc of `RoutableKafkaE2E` on how it verifies the ingress' functionality.
---
### Verifying
Run `mvn clean verify -Prun-e2e-tests` to run the E2E test (or in the IDE).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services