mod_rewrite: different behaviour on sub-requests - Why?

[Ro...@spz.uni-karlsruhe.de]

Hello everybody!

Can somebody enlight me what this code in mod_rewrite.c is good for?

static int hook_fixup(request_rec *r)
{
   [...]
    /* we shouldn't do anything in subrequests */
    if (r->main != NULL) {
        return DECLINED;
    }

It took me days to track down what is is not good for
(see bug http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21814 ).

I suggest to disarm this section if not removing it from mod_rewrite.c...


Any hints?

Robert

Re: mod_rewrite: different behaviour on sub-requests - Why?

[André Malo <nd...@perlig.de>]

* Robert.Siemer@spz.uni-karlsruhe.de wrote:

> Can somebody enlight me what this code in mod_rewrite.c is good for?
> 
> static int hook_fixup(request_rec *r)
> {
>    [...]
>     /* we shouldn't do anything in subrequests */
>     if (r->main != NULL) {
>         return DECLINED;
>     }
> 
> It took me days to track down what is is not good for
> (see bug http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21814 ).
> 
> I suggest to disarm this section if not removing it from mod_rewrite.c...

This was added immediately after the inclusion of mod_rewrite into the httpd
code (some years ago). I believe, the only one who can say, _why_ this was
added, is Ralf :).
However, I'll take a look into it. This was probably added in order to avoid
mod_rewrite-loops. Perhaps it isn't necessary any longer.

nd