You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xumingming (via GitHub)" <gi...@apache.org> on 2026/10/18 11:13:14 UTC

Re: [PR] [SPARK-58891][SQL] Reorder Window stacks to reduce exchanges [spark]

xumingming commented on PR #58144:
URL: https://github.com/apache/spark/pull/58144#issuecomment-6249199754

   Thanks for the thorough review, @cloud-fan!
   
   1. Restored the legacy pairwise swap at derived-project cuts.
   2. Added a bounded fallback regression to prevent re-transposing a lower reordered chain.
   3. Added coverage that keeps a window consuming a between-link rename above its producing project.
   4. Made group-limit pinning account for cascading `CollapseWindow` merges.
   5. Conservatively pin rank predicates that normalize later, including single-value `IN` and negated comparisons.
   6. Removed the repeated per-attribute link-output scan from stack rebuilding.
   7. Updated the fallback, grouping, and pin-selection comments to describe the shipped behavior.
   8. Corrected and de-duplicated the affected test comments.
   9. Added the selective-pinning coverage where the top rank window reuses a same-spec exchange.
   10. Order groups with collection-producing windows last to avoid carrying wide values through another exchange.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org