You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/05/15 23:33:32 UTC
[kudu-CR] docs: add docs to orchestrate a rolling restart
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15930
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
docs: add docs to orchestrate a rolling restart
Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
---
M docs/administration.adoc
1 file changed, 31 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/15930/1
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15930
to look at the new patch set (#2).
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
docs: add docs to orchestrate a rolling restart
Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
---
M docs/administration.adoc
1 file changed, 35 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/15930/2
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 03:32:15 +0000
Gerrit-HasComments: No
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 17 May 2020 14:28:10 +0000
Gerrit-HasComments: No
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc@1523
PS1, Line 1523: As of Kudu 1.12, Kudu provides tooling to restart a Kudu cluster with no
: downtime
styling nit: too many Kudus in one sentence. What about
As of Kudu 1.12, a tooling is available to restart a cluster with no downtime.
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc@1546
PS1, Line 1546: within a single rack
Why? By my understanding, it's vice versa -- it's possible to do so by working on a single tablet server within each location/rack.
I think this should be:
at different racks/locations, no more than one tablet server per location
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 15:52:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
docs: add docs to orchestrate a rolling restart
Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Reviewed-on: http://gerrit.cloudera.org:8080/15930
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M docs/administration.adoc
1 file changed, 35 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 17 May 2020 15:56:47 +0000
Gerrit-HasComments: No
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc@1523
PS1, Line 1523: Once the downtime is finished, reset the flag to its original value.
:
> styling nit: too many Kudus in one sentence. What about
Done
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc@1546
PS1, Line 1546: `kudu tserver quies
> Whoops, my bad: I conflated this with something else. Indeed, the original
Yeah, I think that would be more like upgrade domains in HDFS, where the placement index in each rack is used as the location, allowing the restarting of a given placement index across all racks at a time while reducing the damage if a rack goes down.
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc@1549
PS1, Line 1549: . Periodically run `kudu tserver quiesce start` with the
> nit: whether if it's assumed or not that the enforcement of location assign
Done
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 23:08:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc@1546
PS1, Line 1546: within a single rack
> Why? By my understanding, it's vice versa -- it's possible to do so by wor
Whoops, my bad: I conflated this with something else. Indeed, the original version is correct.
Please ignore this.
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 15:55:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/15930/1/docs/administration.adoc@1549
PS1, Line 1549: location is restarted at the same time.
nit: whether if it's assumed or not that the enforcement of location assignment policy means having at least 3 locations, maybe it's worth mentioning that at least 3 locations should be defined in the cluster. Something like:
At least three locations should be defined in the cluster to safely restart multiple tablet service within one location.
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 May 2020 18:04:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add docs to orchestrate a rolling restart
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15930 )
Change subject: docs: add docs to orchestrate a rolling restart
......................................................................
Patch Set 1:
A staged version can be found here: https://github.com/andrwng/kudu/blob/docs-1.12/docs/administration.adoc#rolling_restart
--
To view, visit http://gerrit.cloudera.org:8080/15930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 May 2020 23:38:50 +0000
Gerrit-HasComments: No