You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 13:17:06 UTC
[GitHub] [camel-website] psingh587 opened a new pull request #192: Made the
logo shorter in shorter resolutions of screen
psingh587 opened a new pull request #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192
After the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 edited a comment on issue #192: Made the
logo shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192#issuecomment-597679554
> 
>
> This is how the preview looks in my smartphone. :( issue remains.
> But not to worry.Well then let me go ahead with modifying my own #191 . @zregvart
> Hopefully will submit a new commit today itself.
Yes.. I have not made the changes for smaller screen width below 471.
* ( ~ 471px being the smallest after which the logo starts to hide, in that case we can try something else ).* --(as i said in my first comment)
I think you can go with putting search bar in menu for it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #192: Made the logo
shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192#issuecomment-597674715
@zregvart
Thank you sir for your feedback.
I myself think that the idea of putting the search bar in the menu is quite nice. We can do that for resolutions below 471. But beyond 471 and till 1023 px widths i think this looks good with a smaller logo and search bar together
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 closed pull request #192: Made the logo
shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
psingh587 closed pull request #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #192: Made the logo
shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192#issuecomment-597632826
@zregvart
Here's my take on it, Sir.
The bigger logo which is there right now gets hidden behind the search bar, so i tried to making the logo itself smaller. We can keep both the logo(smaller one ) and search box together for smaller resolutions this way ( ~ 471px being the smallest after which the logo starts to hide, in that case we can try something else ).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #192: Made the logo
shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192#issuecomment-597679554
> 
>
> This is how the preview looks in my smartphone. :( issue remains.
> But not to worry.Well then let me go ahead with modifying my own #191 . @zregvart
> Hopefully will submit a new commit today itself.
Yes.. I have not made the changes for smaller screen width below 471. I think you can go with putting search bar in menu for it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #192: Made the logo
shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192#issuecomment-597676951
This is how the preview looks in my smartphone. :( issue remains.
But not to worry.Well then let me go ahead with modifying my own #191 . @zregvart
Hopefully will submit a new commit today itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #192: Made the logo
shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192#issuecomment-597667563
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-192/Preview/index.html).
Nice work @psingh587, I think this is much better than what we have. I'm worried a bit about even smaller widths, I usually test with 360 and 411 widths in Firefox this profile is called "Galaxy S9/S9+ Android 7.0" and "Pixel 2 Android 8.0". It's not as nice with those.
I'm not sure what is the smallest width that we should support, so it might be fine regardless.
My opinion, and I don't have to be right, is that perhaps a combined approach with ideas from both @CSElonewolf and @psingh587 could be the winner here. Idea of putting the search in the menu is very interesting to me. In the long run I'd like the menu on smaller screens to take up the full width of the screen, that way we can increase the spacing and have larger touch targets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #192: Made the logo
shorter in shorter resolutions of screen
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #192: Made the logo shorter in shorter resolutions of screen
URL: https://github.com/apache/camel-website/pull/192#issuecomment-597642583
This is better idea @psingh587 .
@zregvart and @oscerd please have a look and let me know whether I should proceed with the issue #191 or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services