You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2023/07/11 22:53:14 UTC
[GitHub] [arrow-nanoarrow] amoeba opened a new pull request, #255: Fix typo in getting-started.md
amoeba opened a new pull request, #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #255: Various fixes/edits in getting-started.md
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255#discussion_r1261123412
##########
docs/source/getting-started.md:
##########
@@ -364,7 +364,7 @@ static int linesplitter_read_internal(const std::string& src, ArrowArray* out,
src_view.size_bytes -= next_newline + 1;
}
- NANOARROW_RETURN_NOT_OK(ArrowArrayFinishBuildingDefault(tmp.get(), error));
+ NANOARROW_RETURN_NOT_OK(ArrowArrayFinishBuilding(tmp.get(), error));
Review Comment:
This one should definitely be `ArrowArrayFinishBuildingDefault()` (although this changed between 0.1 and 0.2, so perhaps there's a reference to 0.1 above that needs fixing?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] amoeba commented on pull request #255: Various fixes/edits in getting-started.md
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255#issuecomment-1633350206
The issue with `ArrowArrayFinishBuildingDefault` not being found was indeed because the example FetchContent declaration referenced 0.1.0. Fixed and reverted back to `ArrowArrayFinishBuildingDefault` in https://github.com/apache/arrow-nanoarrow/pull/255/commits/8ac330371afdac5a327ee93055c746e46dd15341. So this should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on pull request #255: Various fixes/edits in getting-started.md
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255#issuecomment-1634173467
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] amoeba commented on a diff in pull request #255: Various fixes/edits in getting-started.md
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255#discussion_r1261832550
##########
docs/source/getting-started.md:
##########
@@ -364,7 +364,7 @@ static int linesplitter_read_internal(const std::string& src, ArrowArray* out,
src_view.size_bytes -= next_newline + 1;
}
- NANOARROW_RETURN_NOT_OK(ArrowArrayFinishBuildingDefault(tmp.get(), error));
+ NANOARROW_RETURN_NOT_OK(ArrowArrayFinishBuilding(tmp.get(), error));
Review Comment:
Yep, that was it. See https://github.com/apache/arrow-nanoarrow/pull/255/commits/8ac330371afdac5a327ee93055c746e46dd15341.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #255: Various fixes/edits in getting-started.md
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on pull request #255: Various fixes/edits in getting-started.md
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255#issuecomment-1632463671
Thank you!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org