[GitHub] [nifi] rwithers opened a new pull request #3388: NIFI-1693

[GitBox <gi...@apache.org>]

rwithers opened a new pull request #3388: NIFI-1693 
URL: https://github.com/apache/nifi/pull/3388
 
 
   Thank you for submitting a contribution to Apache NiFi.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
   - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   
   Personal Notes: 
   
   I would pay particular attention to TailFile.java as I had to modify the TestRunner including an option for without validation for one of the tests.  I'm very uncertain about that. 
   
   I did do a pull from master to capture upstream changes before making this draft PR but I did not rebase as recommended. 
   
   I also ran a mvn clean install and verified a successful build but I did not run with the contrib-check flag set.  
   
   I still have a bit more work remaining on this.
   
   After submitting this request I will be re-running the build with contrib check. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services