You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2021/04/03 02:00:08 UTC

[jira] [Updated] (BEAM-8486) Reference to ParallelBundleManager attr "_skip_registration" should be "_registered"

     [ https://issues.apache.org/jira/browse/BEAM-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenneth Knowles updated BEAM-8486:
----------------------------------
    Status: Open  (was: Triage Needed)

> Reference to ParallelBundleManager attr "_skip_registration" should be "_registered"
> ------------------------------------------------------------------------------------
>
>                 Key: BEAM-8486
>                 URL: https://issues.apache.org/jira/browse/BEAM-8486
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Chad Dombrova
>            Priority: P3
>
> It appears there was a mistake in the multiprocess refactor of the BundleManager.  I came across this issue while getting mypy type analysis setup (score one for static type checking!)
>  
> The offending line is here: https://github.com/apache/beam/blob/8d2997f8d7ad84649b8ecb2f7e2ca2eceb91b6d0/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L933
> I think it should be using "_registered", as seen here: https://github.com/apache/beam/blob/8d2997f8d7ad84649b8ecb2f7e2ca2eceb91b6d0/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L1909
> I can easily change the attribute name, but presumably this will change the behavior.  Hopefully for the better, but I don't know enough to say.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)