You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/16 01:54:30 UTC
Re: Review Request 41781: Add test for behavior of the rotating
container logger module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41781/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 4:54 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
* Add new test to `LOGROTATE_` test filter.
* Fix some flakiness (cleanup of subprocesses) in the test.
* Change expectations inside test to match the default behavior of `logrotate`.
Summary (updated)
-----------------
Add test for behavior of the rotating container logger module.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description (updated)
-------
Add test for behavior of the rotating container logger module.
Diffs (updated)
-----
src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640
Diff: https://reviews.apache.org/r/41781/diff/
Testing
-------
This test is run later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41781: Logger Module: Add test for the rotating
container logger module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41781/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 7:41 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Rename from "rotate" to "logrotate".
Summary (updated)
-----------------
Logger Module: Add test for the rotating container logger module.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description (updated)
-------
This test loads a non-default ContainerLogger module that rotates logs (i.e. renaming the head log file) and constrains total log size.
Diffs (updated)
-----
src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640
Diff: https://reviews.apache.org/r/41781/diff/
Testing
-------
This test is run later in the review chain.
Thanks,
Joseph Wu