You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/01/31 01:19:54 UTC
[kudu-CR] [java] fix ITClient test retrying
Hello Alexey Serbin, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12321
to review the following change.
Change subject: [java] fix ITClient test retrying
......................................................................
[java] fix ITClient test retrying
ITClient is flaky due to KUDU-2390, but it's also unable to retry upon
failure. I think this is caused by the static error latch which isn't reset
in between test runs. There's no reason for it to be static; I'm guessing
it's a holdover from when the minicluster state was static.
I also added an @After to close the client instance used by the test, which
will hopefully reduce the amount of log pollution in the retries.
Change-Id: I4a9f6a27541de02bbc8cf9dc3ba72824a6324a08
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
1 file changed, 36 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/12321/1
--
To view, visit http://gerrit.cloudera.org:8080/12321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a9f6a27541de02bbc8cf9dc3ba72824a6324a08
Gerrit-Change-Number: 12321
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [java] fix ITClient test retrying
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12321 )
Change subject: [java] fix ITClient test retrying
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a9f6a27541de02bbc8cf9dc3ba72824a6324a08
Gerrit-Change-Number: 12321
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 31 Jan 2019 08:49:42 +0000
Gerrit-HasComments: No
[kudu-CR] [java] fix ITClient test retrying
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12321 )
Change subject: [java] fix ITClient test retrying
......................................................................
[java] fix ITClient test retrying
ITClient is flaky due to KUDU-2390, but it's also unable to retry upon
failure. I think this is caused by the static error latch which isn't reset
in between test runs. There's no reason for it to be static; I'm guessing
it's a holdover from when the minicluster state was static.
I also added an @After to close the client instance used by the test, which
will hopefully reduce the amount of log pollution in the retries.
Change-Id: I4a9f6a27541de02bbc8cf9dc3ba72824a6324a08
Reviewed-on: http://gerrit.cloudera.org:8080/12321
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
1 file changed, 36 insertions(+), 25 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a9f6a27541de02bbc8cf9dc3ba72824a6324a08
Gerrit-Change-Number: 12321
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] fix ITClient test retrying
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12321 )
Change subject: [java] fix ITClient test retrying
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a9f6a27541de02bbc8cf9dc3ba72824a6324a08
Gerrit-Change-Number: 12321
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 31 Jan 2019 03:12:31 +0000
Gerrit-HasComments: No