[GitHub] [skywalking-banyandb] lujiajing1126 commented on a change in pull request #6: Implement the writing protocol for trace

[GitBox <gi...@apache.org>]

lujiajing1126 commented on a change in pull request #6:
URL: https://github.com/apache/skywalking-banyandb/pull/6#discussion_r645266097



##########
File path: api/fbs/v1/rpc.fbs
##########
@@ -16,10 +16,12 @@
 // under the License.
 
 include "query.fbs";
+include "write.fbs";
 
 namespace banyandb.v1;
 
-// Query is the RPC service exposed
-rpc_service Query {
-    QueryTraces(EntityCriteria):TracesResponse;
-}
\ No newline at end of file
+// Trace is the RPC service exposed
+rpc_service Trace {
+    QueryTraces(EntityCriteria): TracesResponse;

Review comment:
       Since the service already has the name `Trace`, do you still need to duplicate `Traces` in the method?

##########
File path: api/fbs/v1/write.fbs
##########
@@ -0,0 +1,66 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+include "database.fbs";
+
+namespace banyandb.v1;
+
+table String {
+    value: string;
+}
+
+table Int {
+    value: int64;
+}
+
+union ValueType {

Review comment:
       Is it possible/necessary to distinguish single-value and multi-value data types? For example: `String`, `StringArray`? 
   
   For now, it seems every value is a vector which may not be efficient in the storage layer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org