[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6409: Merge H3-index branch to master

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #6409:
URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r552153881



##########
File path: pinot-core/pom.xml
##########
@@ -53,6 +53,11 @@
     </plugins>
   </build>
   <dependencies>
+    <dependency>
+      <groupId>com.uber</groupId>
+      <artifactId>h3</artifactId>
+      <version>3.0.3</version>

Review comment:
       move the version to pom.properties in root pom.xml

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java
##########
@@ -89,6 +93,29 @@ public BaseFilterOperator run() {
     }
   }
 
+  private boolean canApplyH3Index(Predicate predicate, FunctionContext function) {
+    if (function.getFunctionName().equalsIgnoreCase(StDistanceFunction.FUNCTION_NAME)) {
+      Predicate.Type type = predicate.getType();
+      if (type != Predicate.Type.RANGE) {
+        return false;
+      }
+      RangePredicate rangePredicate = (RangePredicate) predicate;
+      // TODO: support lower bound

Review comment:
       file an issue to support lower bound




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org