You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Mikaël Cluseau (JIRA)" <ji...@apache.org> on 2014/03/17 07:31:47 UTC
[jira] [Commented] (CAY-1905) Multi-step prefetching NPE : 1..N..1
with absent N and root with no qualifier
[ https://issues.apache.org/jira/browse/CAY-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937495#comment-13937495 ]
Mikaël Cluseau commented on CAY-1905:
-------------------------------------
I still have a NPE that looks like this case. I use prefetching and rows is null. I could solve the issue with the following patch, if its valid:
diff --git a/cayenne-server/src/main/java/org/apache/cayenne/access/ResultScanParentAttachmentStrategy.java b
index 0e579bc..b34c68e 100644
--- a/cayenne-server/src/main/java/org/apache/cayenne/access/ResultScanParentAttachmentStrategy.java
+++ b/cayenne-server/src/main/java/org/apache/cayenne/access/ResultScanParentAttachmentStrategy.java
@@ -107,6 +107,9 @@ class ResultScanParentAttachmentStrategy implements ParentAttachmentStrategy {
}
List<DataRow> rows = parentNode.getDataRows();
+ if (rows == null) {
+ return;
+ }
int size = objects.size();
for (int i = 0; i < size; i++) {
> Multi-step prefetching NPE : 1..N..1 with absent N and root with no qualifier
> -----------------------------------------------------------------------------
>
> Key: CAY-1905
> URL: https://issues.apache.org/jira/browse/CAY-1905
> Project: Cayenne
> Issue Type: Bug
> Affects Versions: 3.1RC1, 3.2M1
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.1 (final), 3.2.M2
>
>
> When all of these conditions are true in a query with prefetching, the query fails with an NPE:
> 1. Disjoint Prefetching is done as 1..N..1 (actually cardinality may not a q requirement)
> 2. Intermediate entity has no rows. Root entity and final entity do.
> 3. Root query has no qualifier.
> SelectQuery<Gallery> q = SelectQuery.query(Gallery.class);
> q.addPrefetch(Gallery.PAINTING_ARRAY.disjoint());
> q.addPrefetch(Gallery.PAINTING_ARRAY.dot(Painting.TO_ARTIST).disjoint());
> List<Gallery> galleries = context.select(q);
> INFO: SELECT t0.GALLERY_NAME, t0.GALLERY_ID FROM GALLERY t0
> Mar 11, 2014 2:59:01 PM org.apache.cayenne.log.CommonsJdbcEventLogger logSelectCount
> INFO: === returned 3 rows. - took 7 ms.
> Mar 11, 2014 2:59:01 PM org.apache.cayenne.log.CommonsJdbcEventLogger logQuery
> INFO: SELECT t0.ESTIMATED_PRICE, t0.PAINTING_DESCRIPTION, t0.PAINTING_TITLE, t0.ARTIST_ID, t0.GALLERY_ID, t0.PAINTING_ID, t1.GALLERY_ID FROM PAINTING t0 JOIN GALLERY t1 ON (t0.GALLERY_ID = t1.GALLERY_ID)
> Mar 11, 2014 2:59:01 PM org.apache.cayenne.log.CommonsJdbcEventLogger logSelectCount
> INFO: === returned 0 rows. - took 6 ms.
> Mar 11, 2014 2:59:01 PM org.apache.cayenne.log.CommonsJdbcEventLogger logQuery
> INFO: SELECT t0.ARTIST_NAME, t0.DATE_OF_BIRTH, t0.ARTIST_ID FROM ARTIST t0
> Mar 11, 2014 2:59:01 PM org.apache.cayenne.log.CommonsJdbcEventLogger logSelectCount
> INFO: === returned 2 rows. - took 2 ms.
> Mar 11, 2014 2:59:01 PM org.apache.cayenne.log.CommonsJdbcEventLogger logCommitTransaction
> INFO: +++ transaction committed.
> java.lang.NullPointerException
> at org.apache.cayenne.access.ResultScanParentAttachmentStrategy.indexParents(ResultScanParentAttachmentStrategy.java:104)
> at org.apache.cayenne.access.ResultScanParentAttachmentStrategy.linkToParent(ResultScanParentAttachmentStrategy.java:72)
> at org.apache.cayenne.access.HierarchicalObjectResolverNode.objectsFromDataRows(HierarchicalObjectResolverNode.java:70)
> at org.apache.cayenne.access.HierarchicalObjectResolver$DisjointProcessor.startDisjointPrefetch(HierarchicalObjectResolver.java:121)
> at org.apache.cayenne.query.PrefetchTreeNode.traverse(PrefetchTreeNode.java:206)
> at org.apache.cayenne.query.PrefetchTreeNode.traverse(PrefetchTreeNode.java:221)
> at org.apache.cayenne.query.PrefetchTreeNode.traverse(PrefetchTreeNode.java:221)
> at org.apache.cayenne.access.HierarchicalObjectResolver.resolveObjectTree(HierarchicalObjectResolver.java:96)
> at org.apache.cayenne.access.HierarchicalObjectResolver.synchronizedRootResultNodeFromDataRows(HierarchicalObjectResolver.java:78)
> at org.apache.cayenne.access.DataDomainQueryAction$ObjectConversionStrategy.toResultsTree(DataDomainQueryAction.java:605)
> at org.apache.cayenne.access.DataDomainQueryAction$SingleObjectConversionStrategy.convert(DataDomainQueryAction.java:643)
> at org.apache.cayenne.access.DataDomainQueryAction.interceptObjectConversion(DataDomainQueryAction.java:468)
> at org.apache.cayenne.access.DataDomainQueryAction.execute(DataDomainQueryAction.java:129)
> at org.apache.cayenne.access.UnitTestDomainQueryAction.execute(UnitTestDomainQueryAction.java:47)
> at org.apache.cayenne.access.UnitTestDomain.onQueryNoFilters(UnitTestDomain.java:63)
> at org.apache.cayenne.access.DataDomain$DataDomainQueryFilterChain.onQuery(DataDomain.java:847)
> at org.apache.cayenne.access.DataDomain.onQuery(DataDomain.java:602)
> at org.apache.cayenne.util.ObjectContextQueryAction.runQuery(ObjectContextQueryAction.java:350)
> at org.apache.cayenne.util.ObjectContextQueryAction.executePostCache(ObjectContextQueryAction.java:106)
> at org.apache.cayenne.util.ObjectContextQueryAction.execute(ObjectContextQueryAction.java:93)
> at org.apache.cayenne.access.DataContext.onQuery(DataContext.java:962)
> at org.apache.cayenne.access.DataContext.performQuery(DataContext.java:951)
> at org.apache.cayenne.BaseContext.select(BaseContext.java:302)
> at org.apache.cayenne.access.DataContextPrefetchMultistepTest.testToManyToOne_EmptyToMany_NoRootQualifier(DataContextPrefetchMultistepTest.java:300)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:154)
> at junit.framework.TestCase.runBare(TestCase.java:127)
> at junit.framework.TestResult$1.protect(TestResult.java:106)
> at junit.framework.TestResult.runProtected(TestResult.java:124)
> at junit.framework.TestResult.run(TestResult.java:109)
> at junit.framework.TestCase.run(TestCase.java:118)
> at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:131)
> at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
--
This message was sent by Atlassian JIRA
(v6.2#6252)