[GitHub] [hive] vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21

[GitBox <gi...@apache.org>]

vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r333775973
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java
 ##########
 @@ -113,9 +113,8 @@ public RelBuilder filter(Iterable<? extends RexNode> predicates) {
   @Override
   public RelBuilder empty() {
     final RelNode input = build();
-    final RelNode sort = HiveRelFactories.HIVE_SORT_FACTORY.createSort(
-            input, RelCollations.of(), null, literal(0));
-    return this.push(sort);
+    final RelNode filter = HiveRelFactories.HIVE_FILTER_FACTORY.createFilter(input, literal(false));
 
 Review comment:
   Method's comment is outdated (referring to Limit 0)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org