You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/08 09:23:30 UTC
[GitHub] [flink] dawidwys opened a new pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
dawidwys opened a new pull request #16429:
URL: https://github.com/apache/flink/pull/16429
* Remove unnecessary calls to `checkNotClosed`
* Make the `checkNotClosed` private to enable inlining
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16429:
URL: https://github.com/apache/flink/pull/16429#discussion_r666033057
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java
##########
@@ -410,7 +402,7 @@ public WatermarkContext(
}
@Override
- public void collect(T element) {
+ public final void collect(T element) {
checkNotClosed();
Review comment:
Yes. That's point 1. in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16429:
URL: https://github.com/apache/flink/pull/16429#issuecomment-876283058
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 00aeb24385ac654daae6d3639f943cab2d1ebaeb (Thu Sep 23 17:59:56 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #16429:
URL: https://github.com/apache/flink/pull/16429#discussion_r666031058
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java
##########
@@ -410,7 +402,7 @@ public WatermarkContext(
}
@Override
- public void collect(T element) {
+ public final void collect(T element) {
checkNotClosed();
Review comment:
As I can see, `checkNotClosed()` was always called here on all of the code paths, so for example `processAndCollect` was calling it at least twice in the end? One time directly and the other time indirectly via this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #16429:
URL: https://github.com/apache/flink/pull/16429#issuecomment-876311519
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16429:
URL: https://github.com/apache/flink/pull/16429#issuecomment-876315366
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20171",
"triggerID" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"triggerType" : "PUSH"
}, {
"hash" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20173",
"triggerID" : "876311519",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 00aeb24385ac654daae6d3639f943cab2d1ebaeb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20171) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20173)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #16429:
URL: https://github.com/apache/flink/pull/16429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16429:
URL: https://github.com/apache/flink/pull/16429#issuecomment-876315366
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00aeb24385ac654daae6d3639f943cab2d1ebaeb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16429:
URL: https://github.com/apache/flink/pull/16429#issuecomment-876315366
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20171",
"triggerID" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"triggerType" : "PUSH"
}, {
"hash" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20173",
"triggerID" : "876311519",
"triggerType" : "MANUAL"
}, {
"hash" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20173",
"triggerID" : "00aeb24385ac654daae6d3639f943cab2d1ebaeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00aeb24385ac654daae6d3639f943cab2d1ebaeb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20171) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20173)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16429: [FLINK-23308] Optimize checks if SourceContext is closed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16429:
URL: https://github.com/apache/flink/pull/16429#issuecomment-876283058
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e09129e7b221e0986b47b55c7fe58d84dbbbe65a (Thu Jul 08 09:25:45 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org