You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by Elizabeth Thompson <el...@preset.io.INVALID> on 2023/03/14 01:35:01 UTC

[VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Hello Superset Community,

This is a call for the vote to release Apache Superset version 2.1.0.

The release candidate:
https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/

Git tag for the release:
https://github.com/apache/superset/tree/2.1.0rc2

The Change Log for the release:
https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md

The Updating instructions for the release:
https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md

Public keys are available at:
https://www.apache.org/dist/superset/KEYS

The vote will be open for at least 72 hours or until the necessary number
of votes are reached.

Please vote accordingly:

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Thanks,
The Apache Superset Team

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Sam Firke <sa...@gmail.com>.
I've put my testing notes here:
https://github.com/apache/superset/discussions/23357#discussioncomment-5314068

Would love to hear from others who are testing. Looking good, my thanks to
those who worked on rc2 and patched bugs since rc1 !

On Mon, Mar 13, 2023, 9:36 PM Elizabeth Thompson
<el...@preset.io.invalid> wrote:

> Hello Superset Community,
>
> This is a call for the vote to release Apache Superset version 2.1.0.
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
>
> Git tag for the release:
> https://github.com/apache/superset/tree/2.1.0rc2
>
> The Change Log for the release:
> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
>
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
>
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Superset Team
>
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Tai Dupree <td...@gmail.com>.
Personally, I believe that the out of the box support for alerts/reports is
mostly provided for convenience so users can test the feature out and was
never meant to be part of the official release distros (hence why driver
support was only added to the dev image). However, I can already see the
slew of questions and confusion from users not being able to use 2.1.0-dev
image + default config to run alerts/reports.

Given that we've already identified and addressed the issue, I’m in favor
of delaying this release in favor of an RC3 build with
https://github.com/apache/superset/pull/23388 cherry-picked in.

I vote -1 (binding)

On Fri, Mar 17, 2023 at 12:26 PM Sam Firke <sa...@gmail.com> wrote:

>  I can confirm both that:
>
> - my reports broke with 2.1.0rc2, and
> - they are now working, including attaching screenshots, using the docker
> image with Tai's fixes: apache/superset:pr-23388-dev
>
> I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting.  But I think
> Tai's PR provides a suitable fix for a next RC.  And I see no other major
> problems with rc2 that should hold up release.
>
> Sam
>
> On Fri, Mar 17, 2023 at 2:07 PM Tai Dupree <td...@gmail.com> wrote:
>
> > Yes, I was able to receive an email report. You need to use an image
> tagged
> > with dev, you can try apache/superset:pr-23388-dev.
> >
> > On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj
> <Pankaj.Soni@dell.com.invalid
> > >
> > wrote:
> >
> > > Hi,
> > > Are you also able to get screenshots in the mail?
> > > As per your suggestion I tried your fix from recently pushed image:
> > > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > > This incorporates the fix for webdriver. I am able to get reports but
> > > still screenshot gives same error "Failed taking a screenshot Message:
> > > 'geckodriver' executable needs to be in PATH"
> > >
> > > Thanks,
> > > Pankaj
> > >
> > >
> > > Internal Use - Confidential
> > >
> > > -----Original Message-----
> > > From: Tai Dupree <td...@gmail.com>
> > > Sent: Friday, March 17, 2023 11:50 AM
> > > To: dev@superset.apache.org
> > > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > > 2.1.0rc2
> > >
> > >
> > > [EXTERNAL EMAIL]
> > >
> > > I was just able to receive an email report just fine, so I don't think
> > the
> > > issue is with this release (aside from what's addressed in my PR). That
> > > connection timeout error is usually networking/config related. Are you
> > sure
> > > you can reach the superset web server from the worker, and that smtp is
> > > configured correctly?
> > >
> > > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <
> multazimd@gmail.com>
> > > wrote:
> > >
> > > > Hi Pankaj,
> > > >
> > > > Can you give more information to understand the root cause.
> > > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > > version?
> > > > 2. Did you try Tai’s fix ?
> > > > 3. Any details in the log?
> > > >
> > > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > > wrote:
> > > >
> > > > > Sorry to say, but nothing works to fix alert and report.
> > > > > Not only screenshot but also simple reports are getting timeout
> > error.
> > > > >
> > > > > Overall alert and report is completely broken and not working in
> any
> > > way.
> > > > >
> > > > > Thanks,
> > > > > Pankaj
> > > > >
> > > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com>
> > wrote:
> > > > >
> > > > >> FWIW, here's a fix PR
> > > > >>
> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> > > > >>
> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> > > > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > > >>
> > > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <tdupreetan@gmail.com
> >
> > > > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > So for the alerts/reports issue this config needs to be
> > overridden:
> > > > >> >
> > > >
> https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> > > >
> 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> > > > >> a8b635e814/superset/config.py#L1307
> > > > >> >
> > > > >> > I suppose these defaults no longer work with the new
> > > > >> > Firefox/webdriver version. They also seem chrome specific too,
> so
> > > > >> > probably don't make
> > > > >> sense
> > > > >> > as a default. I don't think this should block the release though
> > > > >> > since
> > > > >> the
> > > > >> > firefox/webdriver is only part of the dev image and not part of
> > > > >> > any official release. Maybe we can just add a note in upgrading
> > for
> > > this.
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > > >> > <sa...@gmail.com>
> > > > >> wrote:
> > > > >> >
> > > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > > >> >> at the
> > > > >> logs
> > > > >> >> it appears to be this issue:
> > > > >> >>
> https://urldefense.com/v3/__https://github.com/apache/superset/i
> > > > >> >>
> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQ
> > > > >> >> smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > > >> >>
> > > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > > >> >> <pankajsoni.mgml@gmail.com
> > > > >
> > > > >> >> wrote:
> > > > >> >>
> > > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > > well.
> > > > >> >> >
> > > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > > pankajsoni.mgml@gmail.com>
> > > > >> >> > wrote:
> > > > >> >> >
> > > > >> >> > > -1: Alert & Report section is completely broken as no
> mails,
> > > > >> >> screenshots
> > > > >> >> > > are triggered due to error mentioned in image
> > > > >> >> > >
> > > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > > >> >> > > <el...@preset.io.invalid> wrote:
> > > > >> >> > >
> > > > >> >> > >> Hello Superset Community,
> > > > >> >> > >>
> > > > >> >> > >> This is a call for the vote to release Apache Superset
> > > > >> >> > >> version
> > > > >> 2.1.0.
> > > > >> >> > >>
> > > > >> >> > >> The release candidate:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://dist.apache.org/repos/d
> > > > >> >> > >>
> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUA
> > > > >> >> > >>
> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63PhlqEj
> > > > >> >> > >> o$ [dist[.]apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> Git tag for the release:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://github.com/apache/super
> > > > >> >> > >>
> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > > >> >> > >> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > > >> >> > >> [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Change Log for the release:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://github.com/apache/super
> > > > >> >> > >>
> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6smVZ
> > > > >> >> > >>
> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63M-
> > > > >> >> > >> MLnFs$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Updating instructions for the release:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://github.com/apache/super
> > > > >> >> > >>
> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smVZk
> > > > >> >> > >>
> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_BM
> > > > >> >> > >> pXQI$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> Public keys are available at:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://www.apache.org/dist/sup
> > > > >> >> > >>
> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9
> > > > >> >> > >> RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > > >> >> > >> [apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > > necessary
> > > > >> >> > number
> > > > >> >> > >> of votes are reached.
> > > > >> >> > >>
> > > > >> >> > >> Please vote accordingly:
> > > > >> >> > >>
> > > > >> >> > >> [ ] +1 approve
> > > > >> >> > >> [ ] +0 no opinion
> > > > >> >> > >> [ ] -1 disapprove with the reason
> > > > >> >> > >>
> > > > >> >> > >> Thanks,
> > > > >> >> > >> The Apache Superset Team
> > > > >> >> > >>
> > > > >> >> > >>
> > > > >> >> >
> > > > >> >>
> > > > >> >
> > > > >> >
> > > > >> > --
> > > > >> > -Tai Dupree
> > > > >> >
> > > > >>
> > > > >>
> > > > >> --
> > > > >> -Tai Dupree
> > > > >>
> > > > >
> > > >
> > > > --
> > > > Regards
> > > > Multazim Deshmukh
> > > >
> https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-deshm
> > > >
> ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyM
> > > > q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > > >
> > >
> > >
> > > --
> > > -Tai Dupree
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>


-- 
-Tai Dupree

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Sam Firke <sa...@gmail.com>.
 I can confirm both that:

- my reports broke with 2.1.0rc2, and
- they are now working, including attaching screenshots, using the docker
image with Tai's fixes: apache/superset:pr-23388-dev

I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting.  But I think
Tai's PR provides a suitable fix for a next RC.  And I see no other major
problems with rc2 that should hold up release.

Sam

On Fri, Mar 17, 2023 at 2:07 PM Tai Dupree <td...@gmail.com> wrote:

> Yes, I was able to receive an email report. You need to use an image tagged
> with dev, you can try apache/superset:pr-23388-dev.
>
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pankaj.Soni@dell.com.invalid
> >
> wrote:
>
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think
> the
> > issue is with this release (aside from what's addressed in my PR). That
> > connection timeout error is usually networking/config related. Are you
> sure
> > you can reach the superset web server from the worker, and that smtp is
> > configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <mu...@gmail.com>
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout
> error.
> > > >
> > > > Overall alert and report is completely broken and not working in any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com>
> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> > > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com>
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be
> overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new
> > > >> > Firefox/webdriver version. They also seem chrome specific too, so
> > > >> > probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release though
> > > >> > since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of
> > > >> > any official release. Maybe we can just add a note in upgrading
> for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > >> > <sa...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > >> >> at the
> > > >> logs
> > > >> >> it appears to be this issue:
> > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset/i
> > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQ
> > > >> >> smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > >> >>
> > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > >> >> <pankajsoni.mgml@gmail.com
> > > >
> > > >> >> wrote:
> > > >> >>
> > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > well.
> > > >> >> >
> > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > pankajsoni.mgml@gmail.com>
> > > >> >> > wrote:
> > > >> >> >
> > > >> >> > > -1: Alert & Report section is completely broken as no mails,
> > > >> >> screenshots
> > > >> >> > > are triggered due to error mentioned in image
> > > >> >> > >
> > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > >> >> > > <el...@preset.io.invalid> wrote:
> > > >> >> > >
> > > >> >> > >> Hello Superset Community,
> > > >> >> > >>
> > > >> >> > >> This is a call for the vote to release Apache Superset
> > > >> >> > >> version
> > > >> 2.1.0.
> > > >> >> > >>
> > > >> >> > >> The release candidate:
> > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos/d
> > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUA
> > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63PhlqEj
> > > >> >> > >> o$ [dist[.]apache[.]org]
> > > >> >> > >>
> > > >> >> > >> Git tag for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > >> >> > >> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > >> >> > >> [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Change Log for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6smVZ
> > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63M-
> > > >> >> > >> MLnFs$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Updating instructions for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smVZk
> > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_BM
> > > >> >> > >> pXQI$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> Public keys are available at:
> > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/sup
> > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9
> > > >> >> > >> RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > >> >> > >> [apache[.]org]
> > > >> >> > >>
> > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > necessary
> > > >> >> > number
> > > >> >> > >> of votes are reached.
> > > >> >> > >>
> > > >> >> > >> Please vote accordingly:
> > > >> >> > >>
> > > >> >> > >> [ ] +1 approve
> > > >> >> > >> [ ] +0 no opinion
> > > >> >> > >> [ ] -1 disapprove with the reason
> > > >> >> > >>
> > > >> >> > >> Thanks,
> > > >> >> > >> The Apache Superset Team
> > > >> >> > >>
> > > >> >> > >>
> > > >> >> >
> > > >> >>
> > > >> >
> > > >> >
> > > >> > --
> > > >> > -Tai Dupree
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> -Tai Dupree
> > > >>
> > > >
> > >
> > > --
> > > Regards
> > > Multazim Deshmukh
> > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-deshm
> > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyM
> > > q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>
>
> --
> -Tai Dupree
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Pankaj soni <pa...@gmail.com>.
I agree tai's fix works. I hope it will be incorporated in rc3.

On Sat, 18 Mar, 2023, 01:44 Sam Firke, <sa...@firke.com> wrote:

> I can confirm both that:
>
> - my reports broke with 2.1.0rc2, and
> - they are now working, including attaching screenshots, using the docker
> image with Tai's fixes: apache/superset:pr-23388-dev
>
> I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting.  But I think
> Tai's PR provides a suitable fix for a next RC.  And I see no other major
> problems with rc2 that should hold up release.
>
> Sam
>
> On Fri, Mar 17, 2023 at 2:07 PM Tai Dupree <td...@gmail.com> wrote:
>
> > Yes, I was able to receive an email report. You need to use an image
> tagged
> > with dev, you can try apache/superset:pr-23388-dev.
> >
> > On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj
> <Pankaj.Soni@dell.com.invalid
> > >
> > wrote:
> >
> > > Hi,
> > > Are you also able to get screenshots in the mail?
> > > As per your suggestion I tried your fix from recently pushed image:
> > > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > > This incorporates the fix for webdriver. I am able to get reports but
> > > still screenshot gives same error "Failed taking a screenshot Message:
> > > 'geckodriver' executable needs to be in PATH"
> > >
> > > Thanks,
> > > Pankaj
> > >
> > >
> > > Internal Use - Confidential
> > >
> > > -----Original Message-----
> > > From: Tai Dupree <td...@gmail.com>
> > > Sent: Friday, March 17, 2023 11:50 AM
> > > To: dev@superset.apache.org
> > > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > > 2.1.0rc2
> > >
> > >
> > > [EXTERNAL EMAIL]
> > >
> > > I was just able to receive an email report just fine, so I don't think
> > the
> > > issue is with this release (aside from what's addressed in my PR). That
> > > connection timeout error is usually networking/config related. Are you
> > sure
> > > you can reach the superset web server from the worker, and that smtp is
> > > configured correctly?
> > >
> > > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <
> multazimd@gmail.com>
> > > wrote:
> > >
> > > > Hi Pankaj,
> > > >
> > > > Can you give more information to understand the root cause.
> > > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > > version?
> > > > 2. Did you try Tai’s fix ?
> > > > 3. Any details in the log?
> > > >
> > > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > > wrote:
> > > >
> > > > > Sorry to say, but nothing works to fix alert and report.
> > > > > Not only screenshot but also simple reports are getting timeout
> > error.
> > > > >
> > > > > Overall alert and report is completely broken and not working in
> any
> > > way.
> > > > >
> > > > > Thanks,
> > > > > Pankaj
> > > > >
> > > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com>
> > wrote:
> > > > >
> > > > >> FWIW, here's a fix PR
> > > > >>
> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> > > > >>
> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> > > > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > > >>
> > > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <tdupreetan@gmail.com
> >
> > > > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > So for the alerts/reports issue this config needs to be
> > overridden:
> > > > >> >
> > > >
> https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> > > >
> 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> > > > >> a8b635e814/superset/config.py#L1307
> > > > >> >
> > > > >> > I suppose these defaults no longer work with the new
> > > > >> > Firefox/webdriver version. They also seem chrome specific too,
> so
> > > > >> > probably don't make
> > > > >> sense
> > > > >> > as a default. I don't think this should block the release though
> > > > >> > since
> > > > >> the
> > > > >> > firefox/webdriver is only part of the dev image and not part of
> > > > >> > any official release. Maybe we can just add a note in upgrading
> > for
> > > this.
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > > >> > <sa...@gmail.com>
> > > > >> wrote:
> > > > >> >
> > > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > > >> >> at the
> > > > >> logs
> > > > >> >> it appears to be this issue:
> > > > >> >>
> https://urldefense.com/v3/__https://github.com/apache/superset/i
> > > > >> >>
> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQ
> > > > >> >> smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > > >> >>
> > > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > > >> >> <pankajsoni.mgml@gmail.com
> > > > >
> > > > >> >> wrote:
> > > > >> >>
> > > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > > well.
> > > > >> >> >
> > > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > > pankajsoni.mgml@gmail.com>
> > > > >> >> > wrote:
> > > > >> >> >
> > > > >> >> > > -1: Alert & Report section is completely broken as no
> mails,
> > > > >> >> screenshots
> > > > >> >> > > are triggered due to error mentioned in image
> > > > >> >> > >
> > > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > > >> >> > > <el...@preset.io.invalid> wrote:
> > > > >> >> > >
> > > > >> >> > >> Hello Superset Community,
> > > > >> >> > >>
> > > > >> >> > >> This is a call for the vote to release Apache Superset
> > > > >> >> > >> version
> > > > >> 2.1.0.
> > > > >> >> > >>
> > > > >> >> > >> The release candidate:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://dist.apache.org/repos/d
> > > > >> >> > >>
> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUA
> > > > >> >> > >>
> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63PhlqEj
> > > > >> >> > >> o$ [dist[.]apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> Git tag for the release:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://github.com/apache/super
> > > > >> >> > >>
> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > > >> >> > >> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > > >> >> > >> [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Change Log for the release:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://github.com/apache/super
> > > > >> >> > >>
> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6smVZ
> > > > >> >> > >>
> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63M-
> > > > >> >> > >> MLnFs$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Updating instructions for the release:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://github.com/apache/super
> > > > >> >> > >>
> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smVZk
> > > > >> >> > >>
> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_BM
> > > > >> >> > >> pXQI$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> Public keys are available at:
> > > > >> >> > >>
> https://urldefense.com/v3/__https://www.apache.org/dist/sup
> > > > >> >> > >>
> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9
> > > > >> >> > >> RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > > >> >> > >> [apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > > necessary
> > > > >> >> > number
> > > > >> >> > >> of votes are reached.
> > > > >> >> > >>
> > > > >> >> > >> Please vote accordingly:
> > > > >> >> > >>
> > > > >> >> > >> [ ] +1 approve
> > > > >> >> > >> [ ] +0 no opinion
> > > > >> >> > >> [ ] -1 disapprove with the reason
> > > > >> >> > >>
> > > > >> >> > >> Thanks,
> > > > >> >> > >> The Apache Superset Team
> > > > >> >> > >>
> > > > >> >> > >>
> > > > >> >> >
> > > > >> >>
> > > > >> >
> > > > >> >
> > > > >> > --
> > > > >> > -Tai Dupree
> > > > >> >
> > > > >>
> > > > >>
> > > > >> --
> > > > >> -Tai Dupree
> > > > >>
> > > > >
> > > >
> > > > --
> > > > Regards
> > > > Multazim Deshmukh
> > > >
> https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-deshm
> > > >
> ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyM
> > > > q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > > >
> > >
> > >
> > > --
> > > -Tai Dupree
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Sam Firke <sa...@firke.com>.
I can confirm both that:

- my reports broke with 2.1.0rc2, and
- they are now working, including attaching screenshots, using the docker
image with Tai's fixes: apache/superset:pr-23388-dev

I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting.  But I think
Tai's PR provides a suitable fix for a next RC.  And I see no other major
problems with rc2 that should hold up release.

Sam

On Fri, Mar 17, 2023 at 2:07 PM Tai Dupree <td...@gmail.com> wrote:

> Yes, I was able to receive an email report. You need to use an image tagged
> with dev, you can try apache/superset:pr-23388-dev.
>
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pankaj.Soni@dell.com.invalid
> >
> wrote:
>
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think
> the
> > issue is with this release (aside from what's addressed in my PR). That
> > connection timeout error is usually networking/config related. Are you
> sure
> > you can reach the superset web server from the worker, and that smtp is
> > configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <mu...@gmail.com>
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout
> error.
> > > >
> > > > Overall alert and report is completely broken and not working in any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com>
> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> > > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com>
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be
> overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new
> > > >> > Firefox/webdriver version. They also seem chrome specific too, so
> > > >> > probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release though
> > > >> > since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of
> > > >> > any official release. Maybe we can just add a note in upgrading
> for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > >> > <sa...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > >> >> at the
> > > >> logs
> > > >> >> it appears to be this issue:
> > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset/i
> > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQ
> > > >> >> smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > >> >>
> > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > >> >> <pankajsoni.mgml@gmail.com
> > > >
> > > >> >> wrote:
> > > >> >>
> > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > well.
> > > >> >> >
> > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > pankajsoni.mgml@gmail.com>
> > > >> >> > wrote:
> > > >> >> >
> > > >> >> > > -1: Alert & Report section is completely broken as no mails,
> > > >> >> screenshots
> > > >> >> > > are triggered due to error mentioned in image
> > > >> >> > >
> > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > >> >> > > <el...@preset.io.invalid> wrote:
> > > >> >> > >
> > > >> >> > >> Hello Superset Community,
> > > >> >> > >>
> > > >> >> > >> This is a call for the vote to release Apache Superset
> > > >> >> > >> version
> > > >> 2.1.0.
> > > >> >> > >>
> > > >> >> > >> The release candidate:
> > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos/d
> > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUA
> > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63PhlqEj
> > > >> >> > >> o$ [dist[.]apache[.]org]
> > > >> >> > >>
> > > >> >> > >> Git tag for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > > >> >> > >> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > >> >> > >> [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Change Log for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6smVZ
> > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63M-
> > > >> >> > >> MLnFs$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Updating instructions for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smVZk
> > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_BM
> > > >> >> > >> pXQI$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> Public keys are available at:
> > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/sup
> > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9
> > > >> >> > >> RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > >> >> > >> [apache[.]org]
> > > >> >> > >>
> > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > necessary
> > > >> >> > number
> > > >> >> > >> of votes are reached.
> > > >> >> > >>
> > > >> >> > >> Please vote accordingly:
> > > >> >> > >>
> > > >> >> > >> [ ] +1 approve
> > > >> >> > >> [ ] +0 no opinion
> > > >> >> > >> [ ] -1 disapprove with the reason
> > > >> >> > >>
> > > >> >> > >> Thanks,
> > > >> >> > >> The Apache Superset Team
> > > >> >> > >>
> > > >> >> > >>
> > > >> >> >
> > > >> >>
> > > >> >
> > > >> >
> > > >> > --
> > > >> > -Tai Dupree
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> -Tai Dupree
> > > >>
> > > >
> > >
> > > --
> > > Regards
> > > Multazim Deshmukh
> > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-deshm
> > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyM
> > > q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>
>
> --
> -Tai Dupree
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Sam Firke <sa...@firke.com>.
Yes, both work with 2.1.0-dev.  The difference between those images is that the -dev image is bundled with additional software, including Firefox.  You can see that from looking at the Dockerfile: https://github.com/apache/superset/blob/master/Dockerfile#L105  The browser is needed to take screenshots.

My approach has been to modify my docker-compose file so that I'm using 2.1.0 for the main application container and 2.1.0-dev for the worker containers.  I posted about this on Github Discussions <https://github.com/apache/superset/discussions/22245>.

I expect you and I are not the only ones to be confused by this.  This comes up in Slack regularly.  I updated the Alerts & Reports docs  <https://superset.apache.org/docs/installation/alerts-reports/>to explain why one has to run a "dev" image in production in this case - see the paragraphs beginning with the text "Note: All the components required" ...

I think there's an opportunity to make this easier on new users by bundling the software needed for Alerts & Reports into the main image (my preference) or into a separate new image that isn't called "dev" so that reporting works out of the box.  If there's support for that, I'd be happy to help however I can.

Sam

P.S. If you made it this far and are interested in clarifying labels of docker images, check out this thread re: issues with the current state of pointing new users to the latest tag <https://github.com/apache/superset/discussions/22244>.

On Sun, May 7, 2023, at 9:52 AM, Soni, Pankaj wrote:
> Thanks,
> Emails for text report/alert works for me, but not with screenshot. Emails with screenshot is working for you?
> 
> I am using 2.1.0 and it doesn't work.
> How about 2.1.0-dev I believe 2.1.0 and 2.1.0-dev are same. Ideally
> shouldn’t the fix present in 2.1.0 itself.
> 
> Get Outlook for Android<https://aka.ms/AAb9ysg>
> ________________________________
> From: Sam Firke <sa...@firke.com>
> Sent: Friday, May 5, 2023 9:41:05 PM
> To: dev@superset.apache.org <de...@superset.apache.org>
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
> 
> 
> [EXTERNAL EMAIL]
> 
> This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose worker container and emails work correctly.
> 
> You might consider posting your situation in Slack to see if someone can help troubleshoot the config?
> 
> On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> > I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
> > And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)
> >
> > Can anyone please have a look, Mails are very important feature for Superset.
> >
> >
> > Thanks,
> > Pankaj
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:37 PM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.
> >
> > On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
> > wrote:
> >
> > > Hi,
> > > Are you also able to get screenshots in the mail?
> > > As per your suggestion I tried your fix from recently pushed image:
> > > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > > This incorporates the fix for webdriver. I am able to get reports but
> > > still screenshot gives same error "Failed taking a screenshot Message:
> > > 'geckodriver' executable needs to be in PATH"
> > >
> > > Thanks,
> > > Pankaj
> > >
> > >
> > > Internal Use - Confidential
> > >
> > > -----Original Message-----
> > > From: Tai Dupree <td...@gmail.com>
> > > Sent: Friday, March 17, 2023 11:50 AM
> > > To: dev@superset.apache.org
> > > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > > 2.1.0rc2
> > >
> > >
> > > [EXTERNAL EMAIL]
> > >
> > > I was just able to receive an email report just fine, so I don't think
> > > the issue is with this release (aside from what's addressed in my PR).
> > > That connection timeout error is usually networking/config related.
> > > Are you sure you can reach the superset web server from the worker,
> > > and that smtp is configured correctly?
> > >
> > > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh
> > > <mu...@gmail.com>
> > > wrote:
> > >
> > > > Hi Pankaj,
> > > >
> > > > Can you give more information to understand the root cause.
> > > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > > version?
> > > > 2. Did you try Tai’s fix ?
> > > > 3. Any details in the log?
> > > >
> > > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > > wrote:
> > > >
> > > > > Sorry to say, but nothing works to fix alert and report.
> > > > > Not only screenshot but also simple reports are getting timeout error.
> > > > >
> > > > > Overall alert and report is completely broken and not working in
> > > > > any
> > > way.
> > > > >
> > > > > Thanks,
> > > > > Pankaj
> > > > >
> > > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > > > >
> > > > >> FWIW, here's a fix PR
> > > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > > > >> ll
> > > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > > > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > > >>
> > > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree
> > > > >> <td...@gmail.com>
> > > > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > So for the alerts/reports issue this config needs to be overridden:
> > > > >> >
> > > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > > > da
> > > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$
> > > > [github[.]com]
> > > > >> a8b635e814/superset/config.py#L1307
> > > > >> >
> > > > >> > I suppose these defaults no longer work with the new
> > > > >> > Firefox/webdriver version. They also seem chrome specific too,
> > > > >> > so probably don't make
> > > > >> sense
> > > > >> > as a default. I don't think this should block the release
> > > > >> > though since
> > > > >> the
> > > > >> > firefox/webdriver is only part of the dev image and not part of
> > > > >> > any official release. Maybe we can just add a note in upgrading
> > > > >> > for
> > > this.
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > > >> > <sa...@gmail.com>
> > > > >> wrote:
> > > > >> >
> > > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > > >> >> at the
> > > > >> logs
> > > > >> >> it appears to be this issue:
> > > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > > > >> >> /i
> > > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > > > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > > >> >>
> > > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > > >> >> <pankajsoni.mgml@gmail.com
> > > > >
> > > > >> >> wrote:
> > > > >> >>
> > > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > > well.
> > > > >> >> >
> > > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > > pankajsoni.mgml@gmail.com>
> > > > >> >> > wrote:
> > > > >> >> >
> > > > >> >> > > -1: Alert & Report section is completely broken as no
> > > > >> >> > > mails,
> > > > >> >> screenshots
> > > > >> >> > > are triggered due to error mentioned in image
> > > > >> >> > >
> > > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > > >> >> > > <el...@preset.io.invalid> wrote:
> > > > >> >> > >
> > > > >> >> > >> Hello Superset Community,
> > > > >> >> > >>
> > > > >> >> > >> This is a call for the vote to release Apache Superset
> > > > >> >> > >> version
> > > > >> 2.1.0.
> > > > >> >> > >>
> > > > >> >> > >> The release candidate:
> > > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > > > >> >> > >> /d
> > > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > > > >> >> > >> UA
> > > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > > > >> >> > >> Ej
> > > > >> >> > >> o$ [dist[.]apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> Git tag for the release:
> > > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > > >> >> > >> er
> > > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > > >> >> > >> [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Change Log for the release:
> > > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > > >> >> > >> er
> > > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > > > >> >> > >> VZ
> > > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > > > >> >> > >> M-
> > > > >> >> > >> MLnFs$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Updating instructions for the release:
> > > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > > >> >> > >> er
> > > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > > > >> >> > >> Zk
> > > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > > > >> >> > >> BM
> > > > >> >> > >> pXQI$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> Public keys are available at:
> > > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > > > >> >> > >> up
> > > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > > > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > > >> >> > >> [apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > > necessary
> > > > >> >> > number
> > > > >> >> > >> of votes are reached.
> > > > >> >> > >>
> > > > >> >> > >> Please vote accordingly:
> > > > >> >> > >>
> > > > >> >> > >> [ ] +1 approve
> > > > >> >> > >> [ ] +0 no opinion
> > > > >> >> > >> [ ] -1 disapprove with the reason
> > > > >> >> > >>
> > > > >> >> > >> Thanks,
> > > > >> >> > >> The Apache Superset Team
> > > > >> >> > >>
> > > > >> >> > >>
> > > > >> >> >
> > > > >> >>
> > > > >> >
> > > > >> >
> > > > >> > --
> > > > >> > -Tai Dupree
> > > > >> >
> > > > >>
> > > > >>
> > > > >> --
> > > > >> -Tai Dupree
> > > > >>
> > > > >
> > > >
> > > > --
> > > > Regards
> > > > Multazim Deshmukh
> > > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > > > hm
> > > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > > > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > > >
> > >
> > >
> > > --
> > > -Tai Dupree
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by "Soni, Pankaj" <Pa...@dell.com.INVALID>.
Thanks,
Emails for text report/alert works for me, but not with screenshot. Emails with screenshot is working for you?

I am using 2.1.0 and it doesn't work.
How about 2.1.0-dev I believe 2.1.0 and 2.1.0-dev are same. Ideally
shouldn’t the fix present in 2.1.0 itself.

Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Sam Firke <sa...@firke.com>
Sent: Friday, May 5, 2023 9:41:05 PM
To: dev@superset.apache.org <de...@superset.apache.org>
Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2


[EXTERNAL EMAIL]

This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose worker container and emails work correctly.

You might consider posting your situation in Slack to see if someone can help troubleshoot the config?

On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
> And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)
>
> Can anyone please have a look, Mails are very important feature for Superset.
>
>
> Thanks,
> Pankaj
>
> Internal Use - Confidential
>
> -----Original Message-----
> From: Tai Dupree <td...@gmail.com>
> Sent: Friday, March 17, 2023 11:37 PM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
>
>
> [EXTERNAL EMAIL]
>
> Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.
>
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
> wrote:
>
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think
> > the issue is with this release (aside from what's addressed in my PR).
> > That connection timeout error is usually networking/config related.
> > Are you sure you can reach the superset web server from the worker,
> > and that smtp is configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh
> > <mu...@gmail.com>
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout error.
> > > >
> > > > Overall alert and report is completely broken and not working in
> > > > any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > > >> ll
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree
> > > >> <td...@gmail.com>
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > > da
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$
> > > [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new
> > > >> > Firefox/webdriver version. They also seem chrome specific too,
> > > >> > so probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release
> > > >> > though since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of
> > > >> > any official release. Maybe we can just add a note in upgrading
> > > >> > for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > >> > <sa...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > >> >> at the
> > > >> logs
> > > >> >> it appears to be this issue:
> > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > > >> >> /i
> > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > >> >>
> > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > >> >> <pankajsoni.mgml@gmail.com
> > > >
> > > >> >> wrote:
> > > >> >>
> > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > well.
> > > >> >> >
> > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > pankajsoni.mgml@gmail.com>
> > > >> >> > wrote:
> > > >> >> >
> > > >> >> > > -1: Alert & Report section is completely broken as no
> > > >> >> > > mails,
> > > >> >> screenshots
> > > >> >> > > are triggered due to error mentioned in image
> > > >> >> > >
> > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > >> >> > > <el...@preset.io.invalid> wrote:
> > > >> >> > >
> > > >> >> > >> Hello Superset Community,
> > > >> >> > >>
> > > >> >> > >> This is a call for the vote to release Apache Superset
> > > >> >> > >> version
> > > >> 2.1.0.
> > > >> >> > >>
> > > >> >> > >> The release candidate:
> > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > > >> >> > >> /d
> > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > > >> >> > >> UA
> > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > > >> >> > >> Ej
> > > >> >> > >> o$ [dist[.]apache[.]org]
> > > >> >> > >>
> > > >> >> > >> Git tag for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > >> >> > >> [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Change Log for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > > >> >> > >> VZ
> > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > > >> >> > >> M-
> > > >> >> > >> MLnFs$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Updating instructions for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > > >> >> > >> Zk
> > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > > >> >> > >> BM
> > > >> >> > >> pXQI$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> Public keys are available at:
> > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > > >> >> > >> up
> > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > >> >> > >> [apache[.]org]
> > > >> >> > >>
> > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > necessary
> > > >> >> > number
> > > >> >> > >> of votes are reached.
> > > >> >> > >>
> > > >> >> > >> Please vote accordingly:
> > > >> >> > >>
> > > >> >> > >> [ ] +1 approve
> > > >> >> > >> [ ] +0 no opinion
> > > >> >> > >> [ ] -1 disapprove with the reason
> > > >> >> > >>
> > > >> >> > >> Thanks,
> > > >> >> > >> The Apache Superset Team
> > > >> >> > >>
> > > >> >> > >>
> > > >> >> >
> > > >> >>
> > > >> >
> > > >> >
> > > >> > --
> > > >> > -Tai Dupree
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> -Tai Dupree
> > > >>
> > > >
> > >
> > > --
> > > Regards
> > > Multazim Deshmukh
> > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > > hm
> > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>
>
> --
> -Tai Dupree
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Sam Firke <sa...@firke.com>.
This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose worker container and emails work correctly.

You might consider posting your situation in Slack to see if someone can help troubleshoot the config?

On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
> And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)
> 
> Can anyone please have a look, Mails are very important feature for Superset.
> 
> 
> Thanks,
> Pankaj
> 
> Internal Use - Confidential
> 
> -----Original Message-----
> From: Tai Dupree <td...@gmail.com> 
> Sent: Friday, March 17, 2023 11:37 PM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
> 
> 
> [EXTERNAL EMAIL] 
> 
> Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.
> 
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
> wrote:
> 
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but 
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think 
> > the issue is with this release (aside from what's addressed in my PR). 
> > That connection timeout error is usually networking/config related. 
> > Are you sure you can reach the superset web server from the worker, 
> > and that smtp is configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh 
> > <mu...@gmail.com>
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which 
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout error.
> > > >
> > > > Overall alert and report is completely broken and not working in 
> > > > any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > > >> ll 
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree 
> > > >> <td...@gmail.com>
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > > da 
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ 
> > > [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new 
> > > >> > Firefox/webdriver version. They also seem chrome specific too, 
> > > >> > so probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release 
> > > >> > though since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of 
> > > >> > any official release. Maybe we can just add a note in upgrading 
> > > >> > for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke 
> > > >> > <sa...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking 
> > > >> >> at the
> > > >> logs
> > > >> >> it appears to be this issue:
> > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > > >> >> /i 
> > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > >> >>
> > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni 
> > > >> >> <pankajsoni.mgml@gmail.com
> > > >
> > > >> >> wrote:
> > > >> >>
> > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > well.
> > > >> >> >
> > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > pankajsoni.mgml@gmail.com>
> > > >> >> > wrote:
> > > >> >> >
> > > >> >> > > -1: Alert & Report section is completely broken as no 
> > > >> >> > > mails,
> > > >> >> screenshots
> > > >> >> > > are triggered due to error mentioned in image
> > > >> >> > >
> > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson, 
> > > >> >> > > <el...@preset.io.invalid> wrote:
> > > >> >> > >
> > > >> >> > >> Hello Superset Community,
> > > >> >> > >>
> > > >> >> > >> This is a call for the vote to release Apache Superset 
> > > >> >> > >> version
> > > >> 2.1.0.
> > > >> >> > >>
> > > >> >> > >> The release candidate:
> > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > > >> >> > >> /d 
> > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > > >> >> > >> UA 
> > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > > >> >> > >> Ej
> > > >> >> > >> o$ [dist[.]apache[.]org]
> > > >> >> > >>
> > > >> >> > >> Git tag for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er 
> > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > >> >> > >> [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Change Log for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er 
> > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > > >> >> > >> VZ
> > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > > >> >> > >> M-
> > > >> >> > >> MLnFs$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Updating instructions for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er 
> > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > > >> >> > >> Zk 
> > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > > >> >> > >> BM
> > > >> >> > >> pXQI$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> Public keys are available at:
> > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > > >> >> > >> up
> > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > >> >> > >> [apache[.]org]
> > > >> >> > >>
> > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > necessary
> > > >> >> > number
> > > >> >> > >> of votes are reached.
> > > >> >> > >>
> > > >> >> > >> Please vote accordingly:
> > > >> >> > >>
> > > >> >> > >> [ ] +1 approve
> > > >> >> > >> [ ] +0 no opinion
> > > >> >> > >> [ ] -1 disapprove with the reason
> > > >> >> > >>
> > > >> >> > >> Thanks,
> > > >> >> > >> The Apache Superset Team
> > > >> >> > >>
> > > >> >> > >>
> > > >> >> >
> > > >> >>
> > > >> >
> > > >> >
> > > >> > --
> > > >> > -Tai Dupree
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> -Tai Dupree
> > > >>
> > > >
> > >
> > > --
> > > Regards
> > > Multazim Deshmukh
> > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > > hm 
> > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > >
> >
> >
> > --
> > -Tai Dupree
> >
> 
> 
> --
> -Tai Dupree
>

RE: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by "Soni, Pankaj" <Pa...@dell.com.INVALID>.
I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)

Can anyone please have a look, Mails are very important feature for Superset.


Thanks,
Pankaj

Internal Use - Confidential

-----Original Message-----
From: Tai Dupree <td...@gmail.com> 
Sent: Friday, March 17, 2023 11:37 PM
To: dev@superset.apache.org
Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2


[EXTERNAL EMAIL] 

Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.

On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
wrote:

> Hi,
> Are you also able to get screenshots in the mail?
> As per your suggestion I tried your fix from recently pushed image:
> "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> This incorporates the fix for webdriver. I am able to get reports but 
> still screenshot gives same error "Failed taking a screenshot Message:
> 'geckodriver' executable needs to be in PATH"
>
> Thanks,
> Pankaj
>
>
> Internal Use - Confidential
>
> -----Original Message-----
> From: Tai Dupree <td...@gmail.com>
> Sent: Friday, March 17, 2023 11:50 AM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> 2.1.0rc2
>
>
> [EXTERNAL EMAIL]
>
> I was just able to receive an email report just fine, so I don't think 
> the issue is with this release (aside from what's addressed in my PR). 
> That connection timeout error is usually networking/config related. 
> Are you sure you can reach the superset web server from the worker, 
> and that smtp is configured correctly?
>
> On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh 
> <mu...@gmail.com>
> wrote:
>
> > Hi Pankaj,
> >
> > Can you give more information to understand the root cause.
> > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which 
> > version?
> > 2. Did you try Tai’s fix ?
> > 3. Any details in the log?
> >
> > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> wrote:
> >
> > > Sorry to say, but nothing works to fix alert and report.
> > > Not only screenshot but also simple reports are getting timeout error.
> > >
> > > Overall alert and report is completely broken and not working in 
> > > any
> way.
> > >
> > > Thanks,
> > > Pankaj
> > >
> > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > >
> > >> FWIW, here's a fix PR
> > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > >> ll 
> > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > >>
> > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree 
> > >> <td...@gmail.com>
> > wrote:
> > >>
> > >> > Hi,
> > >> >
> > >> > So for the alerts/reports issue this config needs to be overridden:
> > >> >
> > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > da 
> > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ 
> > [github[.]com]
> > >> a8b635e814/superset/config.py#L1307
> > >> >
> > >> > I suppose these defaults no longer work with the new 
> > >> > Firefox/webdriver version. They also seem chrome specific too, 
> > >> > so probably don't make
> > >> sense
> > >> > as a default. I don't think this should block the release 
> > >> > though since
> > >> the
> > >> > firefox/webdriver is only part of the dev image and not part of 
> > >> > any official release. Maybe we can just add a note in upgrading 
> > >> > for
> this.
> > >> >
> > >> >
> > >> >
> > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke 
> > >> > <sa...@gmail.com>
> > >> wrote:
> > >> >
> > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking 
> > >> >> at the
> > >> logs
> > >> >> it appears to be this issue:
> > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > >> >> /i 
> > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > >> >>
> > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni 
> > >> >> <pankajsoni.mgml@gmail.com
> > >
> > >> >> wrote:
> > >> >>
> > >> >> > Not able to send alerts, screenshot as alerts and reports as
> well.
> > >> >> >
> > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > pankajsoni.mgml@gmail.com>
> > >> >> > wrote:
> > >> >> >
> > >> >> > > -1: Alert & Report section is completely broken as no 
> > >> >> > > mails,
> > >> >> screenshots
> > >> >> > > are triggered due to error mentioned in image
> > >> >> > >
> > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson, 
> > >> >> > > <el...@preset.io.invalid> wrote:
> > >> >> > >
> > >> >> > >> Hello Superset Community,
> > >> >> > >>
> > >> >> > >> This is a call for the vote to release Apache Superset 
> > >> >> > >> version
> > >> 2.1.0.
> > >> >> > >>
> > >> >> > >> The release candidate:
> > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > >> >> > >> /d 
> > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > >> >> > >> UA 
> > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > >> >> > >> Ej
> > >> >> > >> o$ [dist[.]apache[.]org]
> > >> >> > >>
> > >> >> > >> Git tag for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > >> >> > >> er 
> > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > >> >> > >> [github[.]com]
> > >> >> > >>
> > >> >> > >> The Change Log for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > >> >> > >> er 
> > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > >> >> > >> VZ
> > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > >> >> > >> M-
> > >> >> > >> MLnFs$ [github[.]com]
> > >> >> > >>
> > >> >> > >> The Updating instructions for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > >> >> > >> er 
> > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > >> >> > >> Zk 
> > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > >> >> > >> BM
> > >> >> > >> pXQI$ [github[.]com]
> > >> >> > >>
> > >> >> > >> Public keys are available at:
> > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > >> >> > >> up
> > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > >> >> > >> [apache[.]org]
> > >> >> > >>
> > >> >> > >> The vote will be open for at least 72 hours or until the
> > necessary
> > >> >> > number
> > >> >> > >> of votes are reached.
> > >> >> > >>
> > >> >> > >> Please vote accordingly:
> > >> >> > >>
> > >> >> > >> [ ] +1 approve
> > >> >> > >> [ ] +0 no opinion
> > >> >> > >> [ ] -1 disapprove with the reason
> > >> >> > >>
> > >> >> > >> Thanks,
> > >> >> > >> The Apache Superset Team
> > >> >> > >>
> > >> >> > >>
> > >> >> >
> > >> >>
> > >> >
> > >> >
> > >> > --
> > >> > -Tai Dupree
> > >> >
> > >>
> > >>
> > >> --
> > >> -Tai Dupree
> > >>
> > >
> >
> > --
> > Regards
> > Multazim Deshmukh
> > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > hm 
> > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> >
>
>
> --
> -Tai Dupree
>


--
-Tai Dupree

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Tai Dupree <td...@gmail.com>.
Yes, I was able to receive an email report. You need to use an image tagged
with dev, you can try apache/superset:pr-23388-dev.

On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
wrote:

> Hi,
> Are you also able to get screenshots in the mail?
> As per your suggestion I tried your fix from recently pushed image:
> "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> This incorporates the fix for webdriver. I am able to get reports but
> still screenshot gives same error "Failed taking a screenshot Message:
> 'geckodriver' executable needs to be in PATH"
>
> Thanks,
> Pankaj
>
>
> Internal Use - Confidential
>
> -----Original Message-----
> From: Tai Dupree <td...@gmail.com>
> Sent: Friday, March 17, 2023 11:50 AM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> 2.1.0rc2
>
>
> [EXTERNAL EMAIL]
>
> I was just able to receive an email report just fine, so I don't think the
> issue is with this release (aside from what's addressed in my PR). That
> connection timeout error is usually networking/config related. Are you sure
> you can reach the superset web server from the worker, and that smtp is
> configured correctly?
>
> On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <mu...@gmail.com>
> wrote:
>
> > Hi Pankaj,
> >
> > Can you give more information to understand the root cause.
> > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > version?
> > 2. Did you try Tai’s fix ?
> > 3. Any details in the log?
> >
> > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> wrote:
> >
> > > Sorry to say, but nothing works to fix alert and report.
> > > Not only screenshot but also simple reports are getting timeout error.
> > >
> > > Overall alert and report is completely broken and not working in any
> way.
> > >
> > > Thanks,
> > > Pankaj
> > >
> > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > >
> > >> FWIW, here's a fix PR
> > >> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > >>
> > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com>
> > wrote:
> > >>
> > >> > Hi,
> > >> >
> > >> > So for the alerts/reports issue this config needs to be overridden:
> > >> >
> > https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> > >> a8b635e814/superset/config.py#L1307
> > >> >
> > >> > I suppose these defaults no longer work with the new
> > >> > Firefox/webdriver version. They also seem chrome specific too, so
> > >> > probably don't make
> > >> sense
> > >> > as a default. I don't think this should block the release though
> > >> > since
> > >> the
> > >> > firefox/webdriver is only part of the dev image and not part of
> > >> > any official release. Maybe we can just add a note in upgrading for
> this.
> > >> >
> > >> >
> > >> >
> > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > >> > <sa...@gmail.com>
> > >> wrote:
> > >> >
> > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > >> >> at the
> > >> logs
> > >> >> it appears to be this issue:
> > >> >> https://urldefense.com/v3/__https://github.com/apache/superset/i
> > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQ
> > >> >> smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > >> >>
> > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > >> >> <pankajsoni.mgml@gmail.com
> > >
> > >> >> wrote:
> > >> >>
> > >> >> > Not able to send alerts, screenshot as alerts and reports as
> well.
> > >> >> >
> > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > pankajsoni.mgml@gmail.com>
> > >> >> > wrote:
> > >> >> >
> > >> >> > > -1: Alert & Report section is completely broken as no mails,
> > >> >> screenshots
> > >> >> > > are triggered due to error mentioned in image
> > >> >> > >
> > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > >> >> > > <el...@preset.io.invalid> wrote:
> > >> >> > >
> > >> >> > >> Hello Superset Community,
> > >> >> > >>
> > >> >> > >> This is a call for the vote to release Apache Superset
> > >> >> > >> version
> > >> 2.1.0.
> > >> >> > >>
> > >> >> > >> The release candidate:
> > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos/d
> > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUA
> > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63PhlqEj
> > >> >> > >> o$ [dist[.]apache[.]org]
> > >> >> > >>
> > >> >> > >> Git tag for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> > >> >> > >> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > >> >> > >> [github[.]com]
> > >> >> > >>
> > >> >> > >> The Change Log for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6smVZ
> > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63M-
> > >> >> > >> MLnFs$ [github[.]com]
> > >> >> > >>
> > >> >> > >> The Updating instructions for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smVZk
> > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_BM
> > >> >> > >> pXQI$ [github[.]com]
> > >> >> > >>
> > >> >> > >> Public keys are available at:
> > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/sup
> > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9
> > >> >> > >> RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > >> >> > >> [apache[.]org]
> > >> >> > >>
> > >> >> > >> The vote will be open for at least 72 hours or until the
> > necessary
> > >> >> > number
> > >> >> > >> of votes are reached.
> > >> >> > >>
> > >> >> > >> Please vote accordingly:
> > >> >> > >>
> > >> >> > >> [ ] +1 approve
> > >> >> > >> [ ] +0 no opinion
> > >> >> > >> [ ] -1 disapprove with the reason
> > >> >> > >>
> > >> >> > >> Thanks,
> > >> >> > >> The Apache Superset Team
> > >> >> > >>
> > >> >> > >>
> > >> >> >
> > >> >>
> > >> >
> > >> >
> > >> > --
> > >> > -Tai Dupree
> > >> >
> > >>
> > >>
> > >> --
> > >> -Tai Dupree
> > >>
> > >
> >
> > --
> > Regards
> > Multazim Deshmukh
> > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-deshm
> > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyM
> > q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> >
>
>
> --
> -Tai Dupree
>


-- 
-Tai Dupree

RE: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by "Soni, Pankaj" <Pa...@dell.com.INVALID>.
Hi,
Are you also able to get screenshots in the mail?
As per your suggestion I tried your fix from recently pushed image: "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
This incorporates the fix for webdriver. I am able to get reports but still screenshot gives same error "Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH"

Thanks,
Pankaj


Internal Use - Confidential

-----Original Message-----
From: Tai Dupree <td...@gmail.com> 
Sent: Friday, March 17, 2023 11:50 AM
To: dev@superset.apache.org
Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2


[EXTERNAL EMAIL] 

I was just able to receive an email report just fine, so I don't think the issue is with this release (aside from what's addressed in my PR). That connection timeout error is usually networking/config related. Are you sure you can reach the superset web server from the worker, and that smtp is configured correctly?

On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <mu...@gmail.com>
wrote:

> Hi Pankaj,
>
> Can you give more information to understand the root cause.
> 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which 
> version?
> 2. Did you try Tai’s fix ?
> 3. Any details in the log?
>
> On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com> wrote:
>
> > Sorry to say, but nothing works to fix alert and report.
> > Not only screenshot but also simple reports are getting timeout error.
> >
> > Overall alert and report is completely broken and not working in any way.
> >
> > Thanks,
> > Pankaj
> >
> > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> >
> >> FWIW, here's a fix PR 
> >> https://urldefense.com/v3/__https://github.com/apache/superset/pull
> >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm
> >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> >>
> >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com>
> wrote:
> >>
> >> > Hi,
> >> >
> >> > So for the alerts/reports issue this config needs to be overridden:
> >> >
> https://urldefense.com/v3/__https://github.com/apache/superset/blob/da
> 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com]
> >> a8b635e814/superset/config.py#L1307
> >> >
> >> > I suppose these defaults no longer work with the new 
> >> > Firefox/webdriver version. They also seem chrome specific too, so 
> >> > probably don't make
> >> sense
> >> > as a default. I don't think this should block the release though 
> >> > since
> >> the
> >> > firefox/webdriver is only part of the dev image and not part of 
> >> > any official release. Maybe we can just add a note in upgrading for this.
> >> >
> >> >
> >> >
> >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke 
> >> > <sa...@gmail.com>
> >> wrote:
> >> >
> >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking 
> >> >> at the
> >> logs
> >> >> it appears to be this issue:
> >> >> https://urldefense.com/v3/__https://github.com/apache/superset/i
> >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQ
> >> >> smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> >> >>
> >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni 
> >> >> <pankajsoni.mgml@gmail.com
> >
> >> >> wrote:
> >> >>
> >> >> > Not able to send alerts, screenshot as alerts and reports as well.
> >> >> >
> >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> pankajsoni.mgml@gmail.com>
> >> >> > wrote:
> >> >> >
> >> >> > > -1: Alert & Report section is completely broken as no mails,
> >> >> screenshots
> >> >> > > are triggered due to error mentioned in image
> >> >> > >
> >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson, 
> >> >> > > <el...@preset.io.invalid> wrote:
> >> >> > >
> >> >> > >> Hello Superset Community,
> >> >> > >>
> >> >> > >> This is a call for the vote to release Apache Superset 
> >> >> > >> version
> >> 2.1.0.
> >> >> > >>
> >> >> > >> The release candidate:
> >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos/d
> >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUA
> >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63PhlqEj
> >> >> > >> o$ [dist[.]apache[.]org]
> >> >> > >>
> >> >> > >> Git tag for the release:
> >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x
> >> >> > >> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$ 
> >> >> > >> [github[.]com]
> >> >> > >>
> >> >> > >> The Change Log for the release:
> >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6smVZ
> >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63M-
> >> >> > >> MLnFs$ [github[.]com]
> >> >> > >>
> >> >> > >> The Updating instructions for the release:
> >> >> > >> https://urldefense.com/v3/__https://github.com/apache/super
> >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smVZk
> >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_BM
> >> >> > >> pXQI$ [github[.]com]
> >> >> > >>
> >> >> > >> Public keys are available at:
> >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/sup
> >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9
> >> >> > >> RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$ 
> >> >> > >> [apache[.]org]
> >> >> > >>
> >> >> > >> The vote will be open for at least 72 hours or until the
> necessary
> >> >> > number
> >> >> > >> of votes are reached.
> >> >> > >>
> >> >> > >> Please vote accordingly:
> >> >> > >>
> >> >> > >> [ ] +1 approve
> >> >> > >> [ ] +0 no opinion
> >> >> > >> [ ] -1 disapprove with the reason
> >> >> > >>
> >> >> > >> Thanks,
> >> >> > >> The Apache Superset Team
> >> >> > >>
> >> >> > >>
> >> >> >
> >> >>
> >> >
> >> >
> >> > --
> >> > -Tai Dupree
> >> >
> >>
> >>
> >> --
> >> -Tai Dupree
> >>
> >
>
> --
> Regards
> Multazim Deshmukh
> https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-deshm
> ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyM
> q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
>


--
-Tai Dupree

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Ville Brofeldt <vi...@gmail.com>.
Hi,

I wonder if this PR might have caused the issues you're seeing? https://github.com/apache/superset/pull/21995 I have a faint recollection of running into issues with the updated versions, and I believe I reverted back to the previous versions (by setting GECKODRIVER_VERSION and FIREFOX_VERSION to 0.28.0 and 88.0 respectively) in my docker builds which fixed it.

Ville


> On 17. Mar 2023, at 8.19, Tai Dupree <td...@gmail.com> wrote:
> 
> I was just able to receive an email report just fine, so I don't think the
> issue is with this release (aside from what's addressed in my PR). That
> connection timeout error is usually networking/config related. Are you sure
> you can reach the superset web server from the worker, and that smtp is
> configured correctly?
> 
> On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <mu...@gmail.com>
> wrote:
> 
>> Hi Pankaj,
>> 
>> Can you give more information to understand the root cause.
>> 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
>> version?
>> 2. Did you try Tai’s fix ?
>> 3. Any details in the log?
>> 
>> On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com> wrote:
>> 
>>> Sorry to say, but nothing works to fix alert and report.
>>> Not only screenshot but also simple reports are getting timeout error.
>>> 
>>> Overall alert and report is completely broken and not working in any way.
>>> 
>>> Thanks,
>>> Pankaj
>>> 
>>> On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
>>> 
>>>> FWIW, here's a fix PR https://github.com/apache/superset/pull/23388
>>>> 
>>>> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com>
>> wrote:
>>>> 
>>>>> Hi,
>>>>> 
>>>>> So for the alerts/reports issue this config needs to be overridden:
>>>>> 
>> https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1
>>>> a8b635e814/superset/config.py#L1307
>>>>> 
>>>>> I suppose these defaults no longer work with the new Firefox/webdriver
>>>>> version. They also seem chrome specific too, so probably don't make
>>>> sense
>>>>> as a default. I don't think this should block the release though since
>>>> the
>>>>> firefox/webdriver is only part of the dev image and not part of any
>>>>> official release. Maybe we can just add a note in upgrading for this.
>>>>> 
>>>>> 
>>>>> 
>>>>> On Wed, Mar 15, 2023 at 9:00 AM Sam Firke <sa...@gmail.com>
>>>> wrote:
>>>>> 
>>>>>> I'm also seeing errors with Alerts and Reports in rc2. Looking at the
>>>> logs
>>>>>> it appears to be this issue:
>>>>>> https://github.com/apache/superset/issues/22326
>>>>>> 
>>>>>> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pankajsoni.mgml@gmail.com
>>> 
>>>>>> wrote:
>>>>>> 
>>>>>>> Not able to send alerts, screenshot as alerts and reports as well.
>>>>>>> 
>>>>>>> On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
>> pankajsoni.mgml@gmail.com>
>>>>>>> wrote:
>>>>>>> 
>>>>>>>> -1: Alert & Report section is completely broken as no mails,
>>>>>> screenshots
>>>>>>>> are triggered due to error mentioned in image
>>>>>>>> 
>>>>>>>> On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
>>>>>>>> <el...@preset.io.invalid> wrote:
>>>>>>>> 
>>>>>>>>> Hello Superset Community,
>>>>>>>>> 
>>>>>>>>> This is a call for the vote to release Apache Superset version
>>>> 2.1.0.
>>>>>>>>> 
>>>>>>>>> The release candidate:
>>>>>>>>> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
>>>>>>>>> 
>>>>>>>>> Git tag for the release:
>>>>>>>>> https://github.com/apache/superset/tree/2.1.0rc2
>>>>>>>>> 
>>>>>>>>> The Change Log for the release:
>>>>>>>>> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
>>>>>>>>> 
>>>>>>>>> The Updating instructions for the release:
>>>>>>>>> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
>>>>>>>>> 
>>>>>>>>> Public keys are available at:
>>>>>>>>> https://www.apache.org/dist/superset/KEYS
>>>>>>>>> 
>>>>>>>>> The vote will be open for at least 72 hours or until the
>> necessary
>>>>>>> number
>>>>>>>>> of votes are reached.
>>>>>>>>> 
>>>>>>>>> Please vote accordingly:
>>>>>>>>> 
>>>>>>>>> [ ] +1 approve
>>>>>>>>> [ ] +0 no opinion
>>>>>>>>> [ ] -1 disapprove with the reason
>>>>>>>>> 
>>>>>>>>> Thanks,
>>>>>>>>> The Apache Superset Team
>>>>>>>>> 
>>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>> --
>>>>> -Tai Dupree
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> -Tai Dupree
>>>> 
>>> 
>> 
>> --
>> Regards
>> Multazim Deshmukh
>> https://www.linkedin.com/in/multazim-deshmukh-a5b68429/
>> 
> 
> 
> -- 
> -Tai Dupree

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Tai Dupree <td...@gmail.com>.
I was just able to receive an email report just fine, so I don't think the
issue is with this release (aside from what's addressed in my PR). That
connection timeout error is usually networking/config related. Are you sure
you can reach the superset web server from the worker, and that smtp is
configured correctly?

On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh <mu...@gmail.com>
wrote:

> Hi Pankaj,
>
> Can you give more information to understand the root cause.
> 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> version?
> 2. Did you try Tai’s fix ?
> 3. Any details in the log?
>
> On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com> wrote:
>
> > Sorry to say, but nothing works to fix alert and report.
> > Not only screenshot but also simple reports are getting timeout error.
> >
> > Overall alert and report is completely broken and not working in any way.
> >
> > Thanks,
> > Pankaj
> >
> > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> >
> >> FWIW, here's a fix PR https://github.com/apache/superset/pull/23388
> >>
> >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com>
> wrote:
> >>
> >> > Hi,
> >> >
> >> > So for the alerts/reports issue this config needs to be overridden:
> >> >
> https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1
> >> a8b635e814/superset/config.py#L1307
> >> >
> >> > I suppose these defaults no longer work with the new Firefox/webdriver
> >> > version. They also seem chrome specific too, so probably don't make
> >> sense
> >> > as a default. I don't think this should block the release though since
> >> the
> >> > firefox/webdriver is only part of the dev image and not part of any
> >> > official release. Maybe we can just add a note in upgrading for this.
> >> >
> >> >
> >> >
> >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke <sa...@gmail.com>
> >> wrote:
> >> >
> >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking at the
> >> logs
> >> >> it appears to be this issue:
> >> >> https://github.com/apache/superset/issues/22326
> >> >>
> >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pankajsoni.mgml@gmail.com
> >
> >> >> wrote:
> >> >>
> >> >> > Not able to send alerts, screenshot as alerts and reports as well.
> >> >> >
> >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> pankajsoni.mgml@gmail.com>
> >> >> > wrote:
> >> >> >
> >> >> > > -1: Alert & Report section is completely broken as no mails,
> >> >> screenshots
> >> >> > > are triggered due to error mentioned in image
> >> >> > >
> >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> >> >> > > <el...@preset.io.invalid> wrote:
> >> >> > >
> >> >> > >> Hello Superset Community,
> >> >> > >>
> >> >> > >> This is a call for the vote to release Apache Superset version
> >> 2.1.0.
> >> >> > >>
> >> >> > >> The release candidate:
> >> >> > >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
> >> >> > >>
> >> >> > >> Git tag for the release:
> >> >> > >> https://github.com/apache/superset/tree/2.1.0rc2
> >> >> > >>
> >> >> > >> The Change Log for the release:
> >> >> > >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
> >> >> > >>
> >> >> > >> The Updating instructions for the release:
> >> >> > >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
> >> >> > >>
> >> >> > >> Public keys are available at:
> >> >> > >> https://www.apache.org/dist/superset/KEYS
> >> >> > >>
> >> >> > >> The vote will be open for at least 72 hours or until the
> necessary
> >> >> > number
> >> >> > >> of votes are reached.
> >> >> > >>
> >> >> > >> Please vote accordingly:
> >> >> > >>
> >> >> > >> [ ] +1 approve
> >> >> > >> [ ] +0 no opinion
> >> >> > >> [ ] -1 disapprove with the reason
> >> >> > >>
> >> >> > >> Thanks,
> >> >> > >> The Apache Superset Team
> >> >> > >>
> >> >> > >>
> >> >> >
> >> >>
> >> >
> >> >
> >> > --
> >> > -Tai Dupree
> >> >
> >>
> >>
> >> --
> >> -Tai Dupree
> >>
> >
>
> --
> Regards
> Multazim Deshmukh
> https://www.linkedin.com/in/multazim-deshmukh-a5b68429/
>


-- 
-Tai Dupree

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by multazim deshmukh <mu...@gmail.com>.
Hi Pankaj,

Can you give more information to understand the root cause.
1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
version?
2. Did you try Tai’s fix ?
3. Any details in the log?

On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com> wrote:

> Sorry to say, but nothing works to fix alert and report.
> Not only screenshot but also simple reports are getting timeout error.
>
> Overall alert and report is completely broken and not working in any way.
>
> Thanks,
> Pankaj
>
> On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
>
>> FWIW, here's a fix PR https://github.com/apache/superset/pull/23388
>>
>> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com> wrote:
>>
>> > Hi,
>> >
>> > So for the alerts/reports issue this config needs to be overridden:
>> > https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1
>> a8b635e814/superset/config.py#L1307
>> >
>> > I suppose these defaults no longer work with the new Firefox/webdriver
>> > version. They also seem chrome specific too, so probably don't make
>> sense
>> > as a default. I don't think this should block the release though since
>> the
>> > firefox/webdriver is only part of the dev image and not part of any
>> > official release. Maybe we can just add a note in upgrading for this.
>> >
>> >
>> >
>> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke <sa...@gmail.com>
>> wrote:
>> >
>> >> I'm also seeing errors with Alerts and Reports in rc2. Looking at the
>> logs
>> >> it appears to be this issue:
>> >> https://github.com/apache/superset/issues/22326
>> >>
>> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pa...@gmail.com>
>> >> wrote:
>> >>
>> >> > Not able to send alerts, screenshot as alerts and reports as well.
>> >> >
>> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <pa...@gmail.com>
>> >> > wrote:
>> >> >
>> >> > > -1: Alert & Report section is completely broken as no mails,
>> >> screenshots
>> >> > > are triggered due to error mentioned in image
>> >> > >
>> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
>> >> > > <el...@preset.io.invalid> wrote:
>> >> > >
>> >> > >> Hello Superset Community,
>> >> > >>
>> >> > >> This is a call for the vote to release Apache Superset version
>> 2.1.0.
>> >> > >>
>> >> > >> The release candidate:
>> >> > >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
>> >> > >>
>> >> > >> Git tag for the release:
>> >> > >> https://github.com/apache/superset/tree/2.1.0rc2
>> >> > >>
>> >> > >> The Change Log for the release:
>> >> > >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
>> >> > >>
>> >> > >> The Updating instructions for the release:
>> >> > >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
>> >> > >>
>> >> > >> Public keys are available at:
>> >> > >> https://www.apache.org/dist/superset/KEYS
>> >> > >>
>> >> > >> The vote will be open for at least 72 hours or until the necessary
>> >> > number
>> >> > >> of votes are reached.
>> >> > >>
>> >> > >> Please vote accordingly:
>> >> > >>
>> >> > >> [ ] +1 approve
>> >> > >> [ ] +0 no opinion
>> >> > >> [ ] -1 disapprove with the reason
>> >> > >>
>> >> > >> Thanks,
>> >> > >> The Apache Superset Team
>> >> > >>
>> >> > >>
>> >> >
>> >>
>> >
>> >
>> > --
>> > -Tai Dupree
>> >
>>
>>
>> --
>> -Tai Dupree
>>
>

-- 
Regards
Multazim Deshmukh
https://www.linkedin.com/in/multazim-deshmukh-a5b68429/

RE: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by "Soni, Pankaj" <Pa...@dell.com.INVALID>.
I believe this can be the strong reason to stop the release and work on the issue. @Tai Dupree<ma...@gmail.com> I think this is a strong reason to block the release, as things are severely broken.

Pankaj

From: Pankaj soni <pa...@gmail.com>
Sent: Friday, March 17, 2023 10:36 AM
To: dev@superset.apache.org
Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2


[EXTERNAL EMAIL]
Sorry to say, but nothing works to fix alert and report.
Not only screenshot but also simple reports are getting timeout error.

Overall alert and report is completely broken and not working in any way.

Thanks,
Pankaj

On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com>> wrote:
FWIW, here's a fix PR https://github.com/apache/superset/pull/23388 [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/pull/23388__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjwaQmH8WQ$>

On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com>> wrote:

> Hi,
>
> So for the alerts/reports issue this config needs to be overridden:
> https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1a8b635e814/superset/config.py#L1307 [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/blob/da3791ad3daa209631a588394600d1a8b635e814/superset/config.py*L1307__;Iw!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjw-fS4WjA$>
>
> I suppose these defaults no longer work with the new Firefox/webdriver
> version. They also seem chrome specific too, so probably don't make sense
> as a default. I don't think this should block the release though since the
> firefox/webdriver is only part of the dev image and not part of any
> official release. Maybe we can just add a note in upgrading for this.
>
>
>
> On Wed, Mar 15, 2023 at 9:00 AM Sam Firke <sa...@gmail.com>> wrote:
>
>> I'm also seeing errors with Alerts and Reports in rc2. Looking at the logs
>> it appears to be this issue:
>> https://github.com/apache/superset/issues/22326 [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/issues/22326__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjypSPuseg$>
>>
>> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pa...@gmail.com>>
>> wrote:
>>
>> > Not able to send alerts, screenshot as alerts and reports as well.
>> >
>> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <pa...@gmail.com>>
>> > wrote:
>> >
>> > > -1: Alert & Report section is completely broken as no mails,
>> screenshots
>> > > are triggered due to error mentioned in image
>> > >
>> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
>> > > <el...@preset.io.invalid>> wrote:
>> > >
>> > >> Hello Superset Community,
>> > >>
>> > >> This is a call for the vote to release Apache Superset version 2.1.0.
>> > >>
>> > >> The release candidate:
>> > >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/ [dist.apache.org]<https://urldefense.com/v3/__https:/dist.apache.org/repos/dist/dev/superset/2.1.0rc2/__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjxoge6aUA$>
>> > >>
>> > >> Git tag for the release:
>> > >> https://github.com/apache/superset/tree/2.1.0rc2 [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/tree/2.1.0rc2__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjzePMQJGg$>
>> > >>
>> > >> The Change Log for the release:
>> > >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjyJnTVbhg$>
>> > >>
>> > >> The Updating instructions for the release:
>> > >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/blob/2.1.0rc2/UPDATING.md__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjzx2WpCFQ$>
>> > >>
>> > >> Public keys are available at:
>> > >> https://www.apache.org/dist/superset/KEYS [apache.org]<https://urldefense.com/v3/__https:/www.apache.org/dist/superset/KEYS__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjxq_xdJSQ$>
>> > >>
>> > >> The vote will be open for at least 72 hours or until the necessary
>> > number
>> > >> of votes are reached.
>> > >>
>> > >> Please vote accordingly:
>> > >>
>> > >> [ ] +1 approve
>> > >> [ ] +0 no opinion
>> > >> [ ] -1 disapprove with the reason
>> > >>
>> > >> Thanks,
>> > >> The Apache Superset Team
>> > >>
>> > >>
>> >
>>
>
>
> --
> -Tai Dupree
>


--
-Tai Dupree


Internal Use - Confidential

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Pankaj soni <pa...@gmail.com>.
Sorry to say, but nothing works to fix alert and report.
Not only screenshot but also simple reports are getting timeout error.

Overall alert and report is completely broken and not working in any way.

Thanks,
Pankaj

On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:

> FWIW, here's a fix PR https://github.com/apache/superset/pull/23388
>
> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com> wrote:
>
> > Hi,
> >
> > So for the alerts/reports issue this config needs to be overridden:
> >
> https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1a8b635e814/superset/config.py#L1307
> >
> > I suppose these defaults no longer work with the new Firefox/webdriver
> > version. They also seem chrome specific too, so probably don't make sense
> > as a default. I don't think this should block the release though since
> the
> > firefox/webdriver is only part of the dev image and not part of any
> > official release. Maybe we can just add a note in upgrading for this.
> >
> >
> >
> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke <sa...@gmail.com>
> wrote:
> >
> >> I'm also seeing errors with Alerts and Reports in rc2. Looking at the
> logs
> >> it appears to be this issue:
> >> https://github.com/apache/superset/issues/22326
> >>
> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pa...@gmail.com>
> >> wrote:
> >>
> >> > Not able to send alerts, screenshot as alerts and reports as well.
> >> >
> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <pa...@gmail.com>
> >> > wrote:
> >> >
> >> > > -1: Alert & Report section is completely broken as no mails,
> >> screenshots
> >> > > are triggered due to error mentioned in image
> >> > >
> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> >> > > <el...@preset.io.invalid> wrote:
> >> > >
> >> > >> Hello Superset Community,
> >> > >>
> >> > >> This is a call for the vote to release Apache Superset version
> 2.1.0.
> >> > >>
> >> > >> The release candidate:
> >> > >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
> >> > >>
> >> > >> Git tag for the release:
> >> > >> https://github.com/apache/superset/tree/2.1.0rc2
> >> > >>
> >> > >> The Change Log for the release:
> >> > >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
> >> > >>
> >> > >> The Updating instructions for the release:
> >> > >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
> >> > >>
> >> > >> Public keys are available at:
> >> > >> https://www.apache.org/dist/superset/KEYS
> >> > >>
> >> > >> The vote will be open for at least 72 hours or until the necessary
> >> > number
> >> > >> of votes are reached.
> >> > >>
> >> > >> Please vote accordingly:
> >> > >>
> >> > >> [ ] +1 approve
> >> > >> [ ] +0 no opinion
> >> > >> [ ] -1 disapprove with the reason
> >> > >>
> >> > >> Thanks,
> >> > >> The Apache Superset Team
> >> > >>
> >> > >>
> >> >
> >>
> >
> >
> > --
> > -Tai Dupree
> >
>
>
> --
> -Tai Dupree
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Tai Dupree <td...@gmail.com>.
FWIW, here's a fix PR https://github.com/apache/superset/pull/23388

On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <td...@gmail.com> wrote:

> Hi,
>
> So for the alerts/reports issue this config needs to be overridden:
> https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1a8b635e814/superset/config.py#L1307
>
> I suppose these defaults no longer work with the new Firefox/webdriver
> version. They also seem chrome specific too, so probably don't make sense
> as a default. I don't think this should block the release though since the
> firefox/webdriver is only part of the dev image and not part of any
> official release. Maybe we can just add a note in upgrading for this.
>
>
>
> On Wed, Mar 15, 2023 at 9:00 AM Sam Firke <sa...@gmail.com> wrote:
>
>> I'm also seeing errors with Alerts and Reports in rc2. Looking at the logs
>> it appears to be this issue:
>> https://github.com/apache/superset/issues/22326
>>
>> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pa...@gmail.com>
>> wrote:
>>
>> > Not able to send alerts, screenshot as alerts and reports as well.
>> >
>> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <pa...@gmail.com>
>> > wrote:
>> >
>> > > -1: Alert & Report section is completely broken as no mails,
>> screenshots
>> > > are triggered due to error mentioned in image
>> > >
>> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
>> > > <el...@preset.io.invalid> wrote:
>> > >
>> > >> Hello Superset Community,
>> > >>
>> > >> This is a call for the vote to release Apache Superset version 2.1.0.
>> > >>
>> > >> The release candidate:
>> > >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
>> > >>
>> > >> Git tag for the release:
>> > >> https://github.com/apache/superset/tree/2.1.0rc2
>> > >>
>> > >> The Change Log for the release:
>> > >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
>> > >>
>> > >> The Updating instructions for the release:
>> > >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
>> > >>
>> > >> Public keys are available at:
>> > >> https://www.apache.org/dist/superset/KEYS
>> > >>
>> > >> The vote will be open for at least 72 hours or until the necessary
>> > number
>> > >> of votes are reached.
>> > >>
>> > >> Please vote accordingly:
>> > >>
>> > >> [ ] +1 approve
>> > >> [ ] +0 no opinion
>> > >> [ ] -1 disapprove with the reason
>> > >>
>> > >> Thanks,
>> > >> The Apache Superset Team
>> > >>
>> > >>
>> >
>>
>
>
> --
> -Tai Dupree
>


-- 
-Tai Dupree

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Tai Dupree <td...@gmail.com>.
Hi,

So for the alerts/reports issue this config needs to be overridden:
https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1a8b635e814/superset/config.py#L1307

I suppose these defaults no longer work with the new Firefox/webdriver
version. They also seem chrome specific too, so probably don't make sense
as a default. I don't think this should block the release though since the
firefox/webdriver is only part of the dev image and not part of any
official release. Maybe we can just add a note in upgrading for this.



On Wed, Mar 15, 2023 at 9:00 AM Sam Firke <sa...@gmail.com> wrote:

> I'm also seeing errors with Alerts and Reports in rc2. Looking at the logs
> it appears to be this issue:
> https://github.com/apache/superset/issues/22326
>
> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pa...@gmail.com>
> wrote:
>
> > Not able to send alerts, screenshot as alerts and reports as well.
> >
> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <pa...@gmail.com>
> > wrote:
> >
> > > -1: Alert & Report section is completely broken as no mails,
> screenshots
> > > are triggered due to error mentioned in image
> > >
> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > <el...@preset.io.invalid> wrote:
> > >
> > >> Hello Superset Community,
> > >>
> > >> This is a call for the vote to release Apache Superset version 2.1.0.
> > >>
> > >> The release candidate:
> > >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
> > >>
> > >> Git tag for the release:
> > >> https://github.com/apache/superset/tree/2.1.0rc2
> > >>
> > >> The Change Log for the release:
> > >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
> > >>
> > >> The Updating instructions for the release:
> > >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
> > >>
> > >> Public keys are available at:
> > >> https://www.apache.org/dist/superset/KEYS
> > >>
> > >> The vote will be open for at least 72 hours or until the necessary
> > number
> > >> of votes are reached.
> > >>
> > >> Please vote accordingly:
> > >>
> > >> [ ] +1 approve
> > >> [ ] +0 no opinion
> > >> [ ] -1 disapprove with the reason
> > >>
> > >> Thanks,
> > >> The Apache Superset Team
> > >>
> > >>
> >
>


-- 
-Tai Dupree

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Sam Firke <sa...@gmail.com>.
I'm also seeing errors with Alerts and Reports in rc2. Looking at the logs
it appears to be this issue: https://github.com/apache/superset/issues/22326

On Wed, Mar 15, 2023, 5:27 AM Pankaj soni <pa...@gmail.com> wrote:

> Not able to send alerts, screenshot as alerts and reports as well.
>
> On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <pa...@gmail.com>
> wrote:
>
> > -1: Alert & Report section is completely broken as no mails, screenshots
> > are triggered due to error mentioned in image
> >
> > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > <el...@preset.io.invalid> wrote:
> >
> >> Hello Superset Community,
> >>
> >> This is a call for the vote to release Apache Superset version 2.1.0.
> >>
> >> The release candidate:
> >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
> >>
> >> Git tag for the release:
> >> https://github.com/apache/superset/tree/2.1.0rc2
> >>
> >> The Change Log for the release:
> >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
> >>
> >> The Updating instructions for the release:
> >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
> >>
> >> Public keys are available at:
> >> https://www.apache.org/dist/superset/KEYS
> >>
> >> The vote will be open for at least 72 hours or until the necessary
> number
> >> of votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thanks,
> >> The Apache Superset Team
> >>
> >>
>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Pankaj soni <pa...@gmail.com>.
Not able to send alerts, screenshot as alerts and reports as well.

On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <pa...@gmail.com> wrote:

> -1: Alert & Report section is completely broken as no mails, screenshots
> are triggered due to error mentioned in image
>
> On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> <el...@preset.io.invalid> wrote:
>
>> Hello Superset Community,
>>
>> This is a call for the vote to release Apache Superset version 2.1.0.
>>
>> The release candidate:
>> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
>>
>> Git tag for the release:
>> https://github.com/apache/superset/tree/2.1.0rc2
>>
>> The Change Log for the release:
>> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
>>
>> The Updating instructions for the release:
>> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
>>
>> Public keys are available at:
>> https://www.apache.org/dist/superset/KEYS
>>
>> The vote will be open for at least 72 hours or until the necessary number
>> of votes are reached.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks,
>> The Apache Superset Team
>>
>>

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

Posted by Pankaj soni <pa...@gmail.com>.
-1: Alert & Report section is completely broken as no mails, screenshots
are triggered due to error mentioned in image

On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson, <el...@preset.io.invalid>
wrote:

> Hello Superset Community,
>
> This is a call for the vote to release Apache Superset version 2.1.0.
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/
>
> Git tag for the release:
> https://github.com/apache/superset/tree/2.1.0rc2
>
> The Change Log for the release:
> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md
>
> The Updating instructions for the release:
> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md
>
> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Superset Team
>
>