You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/30 07:20:19 UTC
[GitHub] [spark] LuciferYang commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock
LuciferYang commented on a change in pull request #34745:
URL: https://github.com/apache/spark/pull/34745#discussion_r758992879
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProviderSuite.scala
##########
@@ -68,12 +69,20 @@ class ConnectionProviderSuite
override def canHandle(driver: Driver, options: Map[String, String]): Boolean = true
override def getConnection(driver: Driver, options: Map[String, String]): Connection =
throw new RuntimeException()
+ override def needsModifySecurityConfiguration(
Review comment:
Should I write the default method to `JdbcConnectionProvider` (return false) and override it only where necessary
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProviderSuite.scala
##########
@@ -68,12 +69,20 @@ class ConnectionProviderSuite
override def canHandle(driver: Driver, options: Map[String, String]): Boolean = true
override def getConnection(driver: Driver, options: Map[String, String]): Connection =
throw new RuntimeException()
+ override def needsModifySecurityConfiguration(
Review comment:
Should we write the default method to `JdbcConnectionProvider` (return false) and override it only where necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org