[jira] [Created] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

["Ted Yu (JIRA)" <ji...@apache.org>]

Ted Yu created YARN-2117:
----------------------------

             Summary: Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
                 Key: YARN-2117
                 URL: https://issues.apache.org/jira/browse/YARN-2117
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


Here is related code:
{code}
        Reader reader = new FileReader(signatureSecretFile);
        int c = reader.read();
        while (c > -1) {
          secret.append((char) c);
          c = reader.read();
        }
        reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)