You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/11/08 09:15:10 UTC

[isis] branch master updated: ISIS-2871: don't restrict digit facets to BigDecimal type (2)

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new e7ea958  ISIS-2871: don't restrict digit facets to BigDecimal type (2)
e7ea958 is described below

commit e7ea958736f687febdbf113e3bd7ab2fbfc44209
Author: Andi Huber <ah...@apache.org>
AuthorDate: Mon Nov 8 10:15:01 2021 +0100

    ISIS-2871: don't restrict digit facets to BigDecimal type (2)
---
 .../semantics/ValueSemanticsAnnotationFacetFactory.java     | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/semantics/ValueSemanticsAnnotationFacetFactory.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/semantics/ValueSemanticsAnnotationFacetFactory.java
index 24e3e48..746ba86 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/semantics/ValueSemanticsAnnotationFacetFactory.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/semantics/ValueSemanticsAnnotationFacetFactory.java
@@ -18,7 +18,6 @@
  */
 package org.apache.isis.core.metamodel.facets.value.semantics;
 
-import java.math.BigDecimal;
 import java.util.Optional;
 
 import javax.inject.Inject;
@@ -53,10 +52,10 @@ extends FacetFactoryAbstract {
 
         // support for @javax.validation.constraints.Digits
         val digitsIfAny = processMethodContext
-                    .synthesizeOnMethodOrMixinType(
-                            Digits.class,
-                            () -> MetaModelValidatorForAmbiguousMixinAnnotations
-                                .addValidationFailure(processMethodContext.getFacetHolder(), Digits.class));
+                .synthesizeOnMethodOrMixinType(
+                        Digits.class,
+                        () -> MetaModelValidatorForAmbiguousMixinAnnotations
+                            .addValidationFailure(processMethodContext.getFacetHolder(), Digits.class));
 
         processAll(processMethodContext.getFacetHolder(), valueSemanticsIfAny, digitsIfAny);
     }
@@ -66,9 +65,7 @@ extends FacetFactoryAbstract {
         val valueSemanticsIfAny = processParameterContext.synthesizeOnParameter(ValueSemantics.class);
 
         // support for @javax.validation.constraints.Digits
-        val digitsIfAny = BigDecimal.class == processParameterContext.getParameterType()
-                ? processParameterContext.synthesizeOnParameter(Digits.class)
-                : Optional.<Digits>empty();
+        val digitsIfAny = processParameterContext.synthesizeOnParameter(Digits.class);
 
         processAll(processParameterContext.getFacetHolder(), valueSemanticsIfAny, digitsIfAny);
     }