[GitHub] Ngone51 commented on a change in pull request #23386: [SPARK-26446][CORE] Add cachedExecutorIdleTimeout docs at ExecutorAllocationManager

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #23386: [SPARK-26446][CORE] Add cachedExecutorIdleTimeout docs at ExecutorAllocationManager
URL: https://github.com/apache/spark/pull/23386#discussion_r244267939
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
 ##########
 @@ -57,7 +57,8 @@ import org.apache.spark.util.{Clock, SystemClock, ThreadUtils, Utils}
  * a long time to ramp up under heavy workloads.
  *
  * The remove policy is simpler: If an executor has been idle for K seconds, meaning it has not
- * been scheduled to run any tasks, then it is removed.
+ * been scheduled to run any tasks, then it is removed. Note that if an executor caching any data
+ * blocks will be removed until it has been idle for more then L seconds.
 
 Review comment:
   How about remove `if` and change `until` to `if` ot `once` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org